-
Notifications
You must be signed in to change notification settings - Fork 4
Description
What
Problem Description
I suspect that the changes in the Pom or Lombok configurations introduced in PR #456 might not have been necessary for the tests to pass. Upon initial review, the adjustments to the pom.xml and the introduction of a lombok.config file seem primarily aimed at resolving annotation processing problems related to Lombok, but their necessity must be cross-examined.
Investigation Requested:
- Were the
pom.xmlupdates essential to enable annotation processing effectively? - Was the
lombok.configcrucial, or could other alternatives have been employed? - Could the same functionality and test results have been achieved without these changes?
Finally, we should validate if these changes introduce any secondary impacts on the starter, its dependencies, or consuming projects.
Steps to Verify
- Roll back or comment out the changes in
pom.xmland rerun the tests. - Remove or alter
lombok.configand confirm if any issues arise. - Ensure tests still validate critical scenarios when dependencies and configurations remain unchanged.
Expected Outcome
An outcome that identifies whether these adjustments were indispensable for the passing tests and ensures no unintended functionality or build impacts were introduced.
This issue originated from a concern about PR #456 [Link to PR: https://github.com//pull/456] and is open to further exploration and discussion.
Requested by: @thomasturrell
Why
To avoid adding unnecessary code and configuration
Notes
No response