"Keyboard shortcuts changed" appears at all preference changes

[koppor]

I enabled AI in the settings.

I press "Save"

I get "Keyboard shortcuts changed"

Maybe caused by #14312 ? CC @AmandaBalderas20

The popup should not appear if no keyboard shortcuts changed.

[adrosos89]

Hello! I found that the problem caused by the alteration of the storeSettings method implemented in KeyBindingsTabViewModel class. When I tried the previous implementation (before #14312), the popup didn't emerge (if no keyboard shortcuts changed), I think because of the "if" statement. But I noticed something else. When a preference change (other than keyboard shortcuts and language), a warning popup doesn't appear. I tried to remove "if (!restartWarnings.isEmpty())" from the storeSettings method implementation in PreferencesDialogViewModel class and the the warning popup appear (without a message for the preference I changed). Do you need a message for any preference that is changed (like "Keyboard shortcuts changed")?

[koppor]

@adrosos89 There should be no restart required after #14400 is fixed. We optimistically removed the warning. It should be kept away.

[nthsneha]

/assign-me

[jabref-machine]

👋 Hey @nthsneha, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and set up your local development workspace by following the steps in our workspace setup guidelines to get started smoothly.

For questions on JabRef functionality, you can consult the JabRef Guru. For questions related to the codebase, please start using DeepWiki.

In case you encounter failing tests during development, please check our developer FAQs!

Still facing issues or having more questions? Feel free to ask here on GitHub or on JabRef's Gitter chat. Please don't hesitate to open a (draft) pull request early on to show the direction you are heading towards if unsure.

Happy coding! 🚀

[nthsneha]

/unassign-me

[jabref-machine]

📋 Assignment Update

Hi @nthsneha, due to inactivity, you have been unassigned from this issue.

Next steps

If you still want to work on this:

• Submit a pull request showing your current state. You will be automatically assigned again.
• Ask a maintainer to assign you again.