From 420f34faab5e36288697b641a3f85abb68230013 Mon Sep 17 00:00:00 2001 From: cgombauld Date: Tue, 6 Jan 2026 09:16:20 +0100 Subject: [PATCH] fix(tarball): fix npm tarball tests on windows by normalizing paths --- .changeset/ripe-yaks-cheer.md | 5 +++++ workspaces/tarball/test/NpmTarball.spec.ts | 18 +++++++++--------- 2 files changed, 14 insertions(+), 9 deletions(-) create mode 100644 .changeset/ripe-yaks-cheer.md diff --git a/.changeset/ripe-yaks-cheer.md b/.changeset/ripe-yaks-cheer.md new file mode 100644 index 00000000..80153477 --- /dev/null +++ b/.changeset/ripe-yaks-cheer.md @@ -0,0 +1,5 @@ +--- +"@nodesecure/tarball": minor +--- + +fix(tarball): fix npm tarball tests on windows by normalizing paths diff --git a/workspaces/tarball/test/NpmTarball.spec.ts b/workspaces/tarball/test/NpmTarball.spec.ts index 57bcd6aa..81c3bffe 100644 --- a/workspaces/tarball/test/NpmTarball.spec.ts +++ b/workspaces/tarball/test/NpmTarball.spec.ts @@ -36,7 +36,7 @@ describe("NpmTarball", () => { location: [[[1, 18], [1, 50]]] as SourceArrayLocation[], source: "Scanner", value: "10.0.0.1.sslip.io", - file: `${kShadyLinkPath}/private-ip-1` + file: path.join(kShadyLinkPath, "private-ip-1") }, { ...warnings["shady-link"], @@ -44,14 +44,14 @@ describe("NpmTarball", () => { location: [[[3, 19], [3, 51]]] as SourceArrayLocation[], source: "Scanner", value: "10.0.0.1.sslip.io", - file: `${kShadyLinkPath}/private-ip-2` + file: path.join(kShadyLinkPath, "private-ip-2") }, { ...warnings["shady-link"], kind: "shady-link", location: [[[1, 18], [1, 50]]] as SourceArrayLocation[], source: "Scanner", - file: `${kShadyLinkPath}/private-ip-2`, + file: path.join(kShadyLinkPath, "private-ip-2"), value: "192-168-1-250.sslip.io" }].sort(compareWarning) ); @@ -71,7 +71,7 @@ describe("NpmTarball", () => { location: [[[1, 18], [1, 50]]] as SourceArrayLocation[], source: "Scanner", value: "10.0.0.1.sslip.io", - file: `${kShadyLinkPath}/private-ip-1` + file: path.join(kShadyLinkPath, "private-ip-1") }, { ...warnings["shady-link"], @@ -79,14 +79,14 @@ describe("NpmTarball", () => { location: [[[3, 19], [3, 51]]] as SourceArrayLocation[], source: "Scanner", value: "10.0.0.1.sslip.io", - file: `${kShadyLinkPath}/private-ip-2` + file: path.join(kShadyLinkPath, "private-ip-2") }, { ...warnings["shady-link"], kind: "shady-link", location: [[[1, 18], [1, 50]]] as SourceArrayLocation[], source: "Scanner", - file: `${kShadyLinkPath}/private-ip-2`, + file: path.join(kShadyLinkPath, "private-ip-2"), value: "192-168-1-250.sslip.io" }].sort(compareWarning) ); @@ -108,7 +108,7 @@ describe("NpmTarball", () => { location: [[[1, 18], [1, 50]]] as SourceArrayLocation[], source: "Scanner", value: "10.0.0.1.sslip.io", - file: `${kShadyLinkPath}/private-ip-1` + file: path.join(kShadyLinkPath, "private-ip-1") }, { ...warnings["shady-link"], @@ -116,14 +116,14 @@ describe("NpmTarball", () => { location: [[[3, 19], [3, 51]]] as SourceArrayLocation[], source: "Scanner", value: "10.0.0.1.sslip.io", - file: `${kShadyLinkPath}/private-ip-2` + file: path.join(kShadyLinkPath, "private-ip-2") }, { ...warnings["shady-link"], kind: "shady-link", location: [[[1, 18], [1, 50]]] as SourceArrayLocation[], source: "Scanner", - file: `${kShadyLinkPath}/private-ip-2`, + file: path.join(kShadyLinkPath, "private-ip-2"), value: "192-168-1-250.sslip.io" }].sort(compareWarning) );