-
Notifications
You must be signed in to change notification settings - Fork 6
Closed
Description
Issue Description
The PDF and Word controllers in OsmoDoc.API create temporary files that are not being fully cleaned up after processing, which could lead to disk bloat over time on busy API instances.
Files Not Being Cleaned Up
In PdfController:
- Input template files (htmlTemplateFilePath/ejsTemplateFilePath) created from base64 data
- Output PDF files (outputFilePath) after conversion to base64 response
In WordController:
- WordDocumentGenerator appears to have no cleanup logic at all
Current Behavior
While PdfDocumentGenerator.GeneratePdf() does delete some internal temporary files (converted HTML, modified HTML, JSON data files), it does not delete the input template files or output files created by the controller.
Context
This issue was identified during code review and the decision was made to keep the current behavior for now but address it in a future enhancement.
References
- PR: feat: make the core functions asynchronous #40
- Comment: feat: make the core functions asynchronous #40 (comment)
- Requested by: @osm-Jatin
Metadata
Metadata
Assignees
Labels
No labels