Brinks: Order field: includesBulkOrder is always false

[brettski]

The includesBulkOrder field is always written as false.
This is a two-step fix

1. Determine field is actually used
2. Fix logic driving field if it is in use, otherwise remove field

[brettski]

It isn't read in brinks, downstream processes need to be reviewed.
Value is written in two placed depending on the order type:

that-api-functions/functions/brinks/src/lib/that/createOrderAndAllocations.js

Lines 57 to 59 in 6765cd2

	includesBulkPurchase:
	newLineItems.filter(li => li.isBulkPurchase === true) > 0,
	};

that-api-functions/functions/brinks/src/lib/createOrderFromCheckout.js

Lines 80 to 82 in 6765cd2

	includesBulkPurchase:
	lineItems.filter(li => li.isBulkPurchase === true) > 0,
	};

I see the issue there, in both.
lineItems.filter(li => li.isBulkPurchase === true) > 0,
should be
lineItems.filter(li => li.isBulkPurchase === true)?.length > 0,

[brettski]

Github org search shows no other matches for includesBulkPurchase

https://github.com/search?q=org%3AThatConference%20includesBulkPurchase&type=code