sshd/auth.sh always returns error-values, because of bad jq args

[kikoshiro]

Hello,

did sshd/auth.sh ever work? Whatever i try, it only produces error-values.
I could track the Problem back to those lines:

jumpbox/sshd/auth.sh

Line 42 in 316686d

jq -r -c -e --arg u "${1}" '.users?.[]? | select(.username? == $u)' "${AUTH_CONFIG_PATH}" 2>/dev/null

jumpbox/sshd/auth.sh

Line 61 in 316686d

user_keys=$(echo "${1}" | jq -r -c .keys?.[]?)

i could fix it by replacing these lines where JQ is failing:
L42:

  jq -r -c -e --arg u "${1}" '.users[] | select(.username == $u)' "${AUTH_CONFIG_PATH}" 2>/dev/null

L61:

  user_keys=$(echo "${1}" | jq -r -c '.keys[]')

I didnt not check "dump_keys_github" so far, actually i commentet this out in my testing.

Cheers

Kiko

[WillFantom]

It is currently working for me without any changes. What do the errors look like?

[kikoshiro]

Ok, so here is how it looks from my point of view, i did run these commands inside the container:

1. Here is my testing /etc/ssh/keys.d/auth.json

f5c38ee5b438:/# cat /etc/ssh/keys.d/auth.json
{
    "settings": {
        "github_enable": false,
        "github_required_org": "my-org"
    },
    "users": [
        {
            "keys": [
                "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAACAQCk+SocPkY2nSFlUuSOC5dWYfb94QSSX4GuOcfrM0CDF6Mxx29BLQsG6Oar2DJw4ytV21oCNXbyG/S+TWzKDKjVOFTNUonTjujW7egUBWPEUJNJmQE5jbIdbsDq6o05yhv13Pb+w40sUfNk6s+0vSBFXkYOZitxa72rTmWFgT4W3B7RrI3mwlwMl0fkXBwUAFMJohY9JuU1SGhH94ftyl0G0z3wPtXHqSrPQwi/UQZfYH/dQ/64TavkvNVmytpDMdb15U3c6KABFmCCdrNMjMvRBMNXcY+ps34x5nd/9dqWbrt/QE8BCPmkaeNeFPqQq5/rJfNgdlgycvyYqgUXOKBPAhyqUpR4MlEQMGRStS7RqPDHskQYOJ3DKlH9Z0VUVrxpPbu3JfAdG25CgqXtcZe8wv8pPzmtyrimqZHT1jlIEzhM6PADj2Kpjt7LshV29T5hURssM8Dg3N84S8LJU3Lj2EoNweszGHvPLaWVmzLIqWz08Ml0/DNnD4bUnBtreFTBvjfQcghIidr2mwswxQHejiU/2nhlxU6mmRiUYHxeH+dohdKzTyetpxiLdspqnL/bPhmMS2dYsRZZh3UWLVkZJqssKvlxnWt5J2tMIDLC0yphrXt1kKg8Wn16CPY+xFFdoxSqI34JxIwICQ4dlQWMJZZi3KM3zQUCL50fijDyDw== root@f5c38ee5b438"
            ],
            "username": "myuser"
        }
    ]
}

2. Here i run the script:

f5c38ee5b438:/# /etc/ssh/auth.sh myuser
f5c38ee5b438:/# /etc/ssh/auth.sh myuser ; echo $?
3
f5c38ee5b438:/#

3. a little test positive with the settings:

#This works
f5c38ee5b438:/# jq -r -c '.settings?' /etc/ssh/keys.d/auth.json
{"github_enable":false,"github_required_org":"my-org"}
f5c38ee5b438:/#

4. Now with Line42

#L42:
f5c38ee5b438:/# jq -r -c -e --arg u "myuser" '.users?.[]? | select(.username? == $u)' /etc/ssh/keys.d/auth.json
jq: error: syntax error, unexpected '[', expecting FORMAT or QQSTRING_START (Unix shell quoting issues?) at <top-level>, line 1:
.users?.[]? | select(.username? == $u)
jq: 1 compile error
f5c38ee5b438:/# #With my fix
f5c38ee5b438:/#  jq -r -c -e --arg u "myuser" '.users[] | select(.username == $u)' /etc/ssh/keys.d/auth.json
{"keys":["ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAACAQCk+SocPkY2nSFlUuSOC5dWYfb94QSSX4GuOcfrM0CDF6Mxx29BLQsG6Oar2DJw4ytV21oCNXbyG/S+TWzKDKjVOFTNUonTjujW7egUBWPEUJNJmQE5jbIdbsDq6o05yhv13Pb+w40sUfNk6s+0vSBFXkYOZitxa72rTmWFgT4W3B7RrI3mwlwMl0fkXBwUAFMJohY9JuU1SGhH94ftyl0G0z3wPtXHqSrPQwi/UQZfYH/dQ/64TavkvNVmytpDMdb15U3c6KABFmCCdrNMjMvRBMNXcY+ps34x5nd/9dqWbrt/QE8BCPmkaeNeFPqQq5/rJfNgdlgycvyYqgUXOKBPAhyqUpR4MlEQMGRStS7RqPDHskQYOJ3DKlH9Z0VUVrxpPbu3JfAdG25CgqXtcZe8wv8pPzmtyrimqZHT1jlIEzhM6PADj2Kpjt7LshV29T5hURssM8Dg3N84S8LJU3Lj2EoNweszGHvPLaWVmzLIqWz08Ml0/DNnD4bUnBtreFTBvjfQcghIidr2mwswxQHejiU/2nhlxU6mmRiUYHxeH+dohdKzTyetpxiLdspqnL/bPhmMS2dYsRZZh3UWLVkZJqssKvlxnWt5J2tMIDLC0yphrXt1kKg8Wn16CPY+xFFdoxSqI34JxIwICQ4dlQWMJZZi3KM3zQUCL50fijDyDw== root@f5c38ee5b438"],"username":"myuser"}
f5c38ee5b438:/#

5. Line61

#L61
f5c38ee5b438:/#  jq -r -c -e --arg u "myuser" '.users[] | select(.username == $u)' /etc/ssh/keys.d/auth.json  | jq -r -c .keys?.[]?
jq: error: syntax error, unexpected '[', expecting FORMAT or QQSTRING_START (Unix shell quoting issues?) at <top-level>, line 1:
.keys?.[]?
jq: 1 compile error
f5c38ee5b438:/#

f5c38ee5b438:/# #with my FIx:
f5c38ee5b438:/#  jq -r -c -e --arg u "myuser" '.users[] | select(.username == $u)' /etc/ssh/keys.d/auth.json |  jq -r -c '.keys[]'
ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAACAQCk+SocPkY2nSFlUuSOC5dWYfb94QSSX4GuOcfrM0CDF6Mxx29BLQsG6Oar2DJw4ytV21oCNXbyG/S+TWzKDKjVOFTNUonTjujW7egUBWPEUJNJmQE5jbIdbsDq6o05yhv13Pb+w40sUfNk6s+0vSBFXkYOZitxa72rTmWFgT4W3B7RrI3mwlwMl0fkXBwUAFMJohY9JuU1SGhH94ftyl0G0z3wPtXHqSrPQwi/UQZfYH/dQ/64TavkvNVmytpDMdb15U3c6KABFmCCdrNMjMvRBMNXcY+ps34x5nd/9dqWbrt/QE8BCPmkaeNeFPqQq5/rJfNgdlgycvyYqgUXOKBPAhyqUpR4MlEQMGRStS7RqPDHskQYOJ3DKlH9Z0VUVrxpPbu3JfAdG25CgqXtcZe8wv8pPzmtyrimqZHT1jlIEzhM6PADj2Kpjt7LshV29T5hURssM8Dg3N84S8LJU3Lj2EoNweszGHvPLaWVmzLIqWz08Ml0/DNnD4bUnBtreFTBvjfQcghIidr2mwswxQHejiU/2nhlxU6mmRiUYHxeH+dohdKzTyetpxiLdspqnL/bPhmMS2dYsRZZh3UWLVkZJqssKvlxnWt5J2tMIDLC0yphrXt1kKg8Wn16CPY+xFFdoxSqI34JxIwICQ4dlQWMJZZi3KM3zQUCL50fijDyDw== root@f5c38ee5b438
f5c38ee5b438:/#

Best Regards

[kikoshiro]

Am I totally wrong about this?
I had a hard time getting this to work.