From 47fe5144a1553f276cfa355d45a578e210385228 Mon Sep 17 00:00:00 2001 From: Alex Dametto Date: Mon, 24 Nov 2025 13:33:41 +0100 Subject: [PATCH 1/2] fix: ensure contains is used as default filter in ComboBox --- packages/react-aria-components/src/ComboBox.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-aria-components/src/ComboBox.tsx b/packages/react-aria-components/src/ComboBox.tsx index 538b381b32a..466c696b5fe 100644 --- a/packages/react-aria-components/src/ComboBox.tsx +++ b/packages/react-aria-components/src/ComboBox.tsx @@ -133,8 +133,8 @@ function ComboBoxInner({props, collection, comboBoxRef: ref}: let validationBehavior = props.validationBehavior ?? formValidationBehavior ?? 'native'; let {contains} = useFilter({sensitivity: 'base'}); let state = useComboBoxState({ - defaultFilter: props.defaultFilter || contains, ...props, + defaultFilter: props.defaultFilter || contains, // If props.items isn't provided, rely on collection filtering (aka listbox.items is provided or defaultItems provided to Combobox) items: props.items, children: undefined, From 52b01b78231e51b0a9209025dae09e642c78922d Mon Sep 17 00:00:00 2001 From: Robert Snow Date: Wed, 17 Dec 2025 13:15:36 +1100 Subject: [PATCH 2/2] add test --- .../test/ComboBox.test.js | 42 ++++++++++++++++++- 1 file changed, 40 insertions(+), 2 deletions(-) diff --git a/packages/react-aria-components/test/ComboBox.test.js b/packages/react-aria-components/test/ComboBox.test.js index b786271a0da..66b6550a848 100644 --- a/packages/react-aria-components/test/ComboBox.test.js +++ b/packages/react-aria-components/test/ComboBox.test.js @@ -147,6 +147,44 @@ describe('ComboBox', () => { expect(options).toHaveLength(1); }); + it('should support undefined defaultFilter', async () => { + let tree = render( + + + +