Skip to content

What about simplifying and isolating the object? And hook issues? #14

@ghost

Description

In the suite.js you have almost the same identical code, and also idential code. Say your
this.test is almost idental to the same function under this.serial except for the options.
All hooks have almost similar code too except for the name. What about gathering it into it's own object and only expose that object? In that way no one could get access to the private part of the prototype, only the parts belonging to the exposed object. Similar things as AVA does, except they also add chaining to the exposed object.

Example:

{
beforeEach...
test...
serial...
}

You will not need to change the API if you do that change.

I also noticed when it comes to the hooks there are code that never exist, and code that never are invoked so the delays isn't working. This one. validateFailure has no effect in your code, so that check will always be false.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions