From 8e87287079fe2f63c6570e21a25671364d5cfd2c Mon Sep 17 00:00:00 2001 From: Dmitry Litvintsev Date: Tue, 23 Dec 2025 14:28:52 -0600 Subject: [PATCH] bulk: avoid spamming log file when requests have already been cleared due to auto-clear flag Motivation: ---------- checkTerminated method generates excessive log due to exception caught when request is not found. This happens all the time if auto-clear is set to true. Modification: ------------- Catch and ignore BulkRequestNotFoundException when retrieving request by ID Result: ------- Less verbose output in the log file Ticket: https://github.com/dCache/dcache/issues/7931 Acked-by: Target: trunk Request: 11.1 11.0 10.2 10.1 10.0 9.2 Require-book: no Require-notes: yes Patch: https://rb.dcache.org/r/14577/ Acked-by: Tigran --- .../org/dcache/services/bulk/handler/BulkRequestHandler.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/modules/dcache-bulk/src/main/java/org/dcache/services/bulk/handler/BulkRequestHandler.java b/modules/dcache-bulk/src/main/java/org/dcache/services/bulk/handler/BulkRequestHandler.java index 9561b88c719..453d9cb6961 100644 --- a/modules/dcache-bulk/src/main/java/org/dcache/services/bulk/handler/BulkRequestHandler.java +++ b/modules/dcache-bulk/src/main/java/org/dcache/services/bulk/handler/BulkRequestHandler.java @@ -171,6 +171,11 @@ public boolean checkTerminated(String id, boolean cancelled) { } }); } + } catch (BulkRequestNotFoundException e) { + /* + * Request has been cleared already. + */ + LOGGER.debug("checkTerminated, request {} was auto-cleared on termination.", id); } catch (BulkStorageException e) { LOGGER.warn("checkTerminated, check for cancel on failure {}: {}.", id, e.toString());