Skip to content

Euro (EUR) is not in self.supported_currencies #3

@dk-WZFinTech

Description

@dk-WZFinTech

With definition of supported rates like:

    def __init__(self):
        """Populate supported currencies list."""
        rates = self.get_rates()['rates']
        self.supported_currencies = [cur for cur in rates]

'EUR' is omitted because is used as base here:

rates = self.get_rates()['rates']

then:

assert exchange_api.is_currency_supported('EUR')

will raise False.

My suggestion to solve it:

  1. Remove supported_currencies variable from Api
  2. Update is_currency_supported about base parameter:
    def is_currency_supported(self, currency, base='EUR'):
        """Populate supported currencies list."""
        rates = self.get_rates(base)['rates']
        supported_currencies = [cur for cur in rates]
        return currency in supported_currencies
  1. Add test cases:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions