-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Description
Multiple .unwrap() calls on SubscriptionMessage::from_json() in pubsub handlers. If serialization fails, the WebSocket handler panics.
Locations
cipherbft/crates/rpc/src/pubsub.rs
Line 298 in 1140ac3
if sink.send(jsonrpsee::SubscriptionMessage::from_json(&msg).unwrap()).await.is_err() { cipherbft/crates/rpc/src/pubsub.rs
Line 335 in 1140ac3
if sink.send(jsonrpsee::SubscriptionMessage::from_json(&msg).unwrap()).await.is_err() { cipherbft/crates/rpc/src/pubsub.rs
Line 373 in 1140ac3
if sink.send(jsonrpsee::SubscriptionMessage::from_json(&msg).unwrap()).await.is_err() { cipherbft/crates/rpc/src/pubsub.rs
Line 408 in 1140ac3
if sink.send(jsonrpsee::SubscriptionMessage::from_json(&msg).unwrap()).await.is_err() { cipherbft/crates/rpc/src/pubsub.rs
Line 446 in 1140ac3
if sink.send(jsonrpsee::SubscriptionMessage::from_json(&msg).unwrap()).await.is_err() {
Severity
High - Can cause denial of service for WebSocket subscribers.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working