Skip to content

Image lightbox is brittle #29

@dnywh

Description

@dnywh

The image lightbox that opens after tapping a listing’s photo (ListingPhotoGallery) has some rough edges:

  • Caps out at quite a small size on larger displays
  • Shows nothing until the image is fully rendered
  • Uses different button UI
  • Images aren’t zoomable on mobile

I’m also wondering if it even needs to be a lightbox. See Wikipedia and Reddit for their implementations:

  • Wikipedia actually renders a new page with a new URL slug. The black background (and quick loading) gives the illusion of lightbox behaviour without the complexity.
  • Reddit is a step in-between.

Matching Wikipedia might be a win-win:

  • Drop complexity and dependency
  • Support zooming
  • Add progressive loading (e.g. blurred image) to show progress
  • Use own UI

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions