Skip to content

Commit 772e04e

Browse files
authored
Fix Geo-rep status parsing (#58)
Signed-off-by: Aravinda Vishwanathapura <aravinda@kadalu.tech>
1 parent b31fb7a commit 772e04e

File tree

1 file changed

+33
-33
lines changed

1 file changed

+33
-33
lines changed

glustercli/cli/parsers.py

Lines changed: 33 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -501,30 +501,30 @@ def parse_georep_status(data, volinfo):
501501
# Get All Sessions
502502
for volume_el in tree.findall("geoRep/volume"):
503503
sessions_el = volume_el.find("sessions")
504-
# Master Volume name if multiple Volumes
505-
mvol = volume_el.find("name").text
504+
# Primary Volume name if multiple Volumes
505+
pvol = volume_el.find("name").text
506506

507507
# For each session, collect the details
508508
for session in sessions_el.findall("session"):
509-
session_slave = "{0}:{1}".format(mvol, session.find(
510-
"session_slave").text)
511-
session_keys.add(session_slave)
512-
gstatus[session_slave] = {}
509+
session_secondary = "{0}:{1}".format(pvol, session.find(
510+
"session_secondary").text)
511+
session_keys.add(session_secondary)
512+
gstatus[session_secondary] = {}
513513

514514
for pair in session.findall('pair'):
515-
master_brick = "{0}:{1}".format(
516-
pair.find("master_node").text,
517-
pair.find("master_brick").text
515+
primary_brick = "{0}:{1}".format(
516+
pair.find("primary_node").text,
517+
pair.find("primary_brick").text
518518
)
519519

520-
gstatus[session_slave][master_brick] = {
521-
"mastervol": mvol,
522-
"slavevol": pair.find("slave").text.split("::")[-1],
523-
"master_node": pair.find("master_node").text,
524-
"master_brick": pair.find("master_brick").text,
525-
"slave_user": pair.find("slave_user").text,
526-
"slave": pair.find("slave").text,
527-
"slave_node": pair.find("slave_node").text,
520+
gstatus[session_secondary][primary_brick] = {
521+
"primary_volume": pvol,
522+
"secondary_volume": pair.find("secondary").text.split("::")[-1],
523+
"primary_node": pair.find("primary_node").text,
524+
"primary_brick": pair.find("primary_brick").text,
525+
"secondary_user": pair.find("secondary_user").text,
526+
"secondary": pair.find("secondary").text,
527+
"secondary_node": pair.find("secondary_node").text,
528528
"status": pair.find("status").text,
529529
"crawl_status": pair.find("crawl_status").text,
530530
"entry": pair.find("entry").text,
@@ -533,7 +533,7 @@ def parse_georep_status(data, volinfo):
533533
"failures": pair.find("failures").text,
534534
"checkpoint_completed": pair.find(
535535
"checkpoint_completed").text,
536-
"master_node_uuid": pair.find("master_node_uuid").text,
536+
"primary_node_uuid": pair.find("primary_node_uuid").text,
537537
"last_synced": pair.find("last_synced").text,
538538
"checkpoint_time": pair.find("checkpoint_time").text,
539539
"checkpoint_completion_time":
@@ -551,38 +551,38 @@ def parse_georep_status(data, volinfo):
551551
# Geo-rep status for that Brick
552552
out = []
553553
for session in session_keys:
554-
mvol, _, slave = session.split(":", 2)
555-
slave = slave.replace("ssh://", "")
556-
master_bricks = all_bricks[mvol]
554+
pvol, _, secondary = session.split(":", 2)
555+
secondary = secondary.replace("ssh://", "")
556+
primary_bricks = all_bricks[pvol]
557557
out.append([])
558-
for brick in master_bricks:
558+
for brick in primary_bricks:
559559
bname = brick["name"]
560560
if gstatus.get(session) and gstatus[session].get(bname, None):
561561
out[-1].append(gstatus[session][bname])
562562
else:
563563
# Offline Status
564564
node, brick_path = bname.split(":")
565-
if "@" not in slave:
566-
slave_user = "root"
565+
if "@" not in secondary:
566+
secondary_user = "root"
567567
else:
568-
slave_user, _ = slave.split("@")
568+
secondary_user, _ = secondary.split("@")
569569

570570
out[-1].append({
571-
"mastervol": mvol,
572-
"slavevol": slave.split("::")[-1],
573-
"master_node": node,
574-
"master_brick": brick_path,
575-
"slave_user": slave_user,
576-
"slave": slave,
577-
"slave_node": "N/A",
571+
"primary_volume": pvol,
572+
"secondary_volume": secondary.split("::")[-1],
573+
"primary_node": node,
574+
"primary_brick": brick_path,
575+
"secondary_user": secondary_user,
576+
"secondary": secondary,
577+
"secondary_node": "N/A",
578578
"status": "Offline",
579579
"crawl_status": "N/A",
580580
"entry": "N/A",
581581
"data": "N/A",
582582
"meta": "N/A",
583583
"failures": "N/A",
584584
"checkpoint_completed": "N/A",
585-
"master_node_uuid": brick["uuid"],
585+
"primary_node_uuid": brick["uuid"],
586586
"last_synced": "N/A",
587587
"checkpoint_time": "N/A",
588588
"checkpoint_completion_time": "N/A"

0 commit comments

Comments
 (0)