Skip to content

icon.png is served when dark_icon@2x.png is requested, even if dark_icon.png is present. #8522

@david-collett

Description

@david-collett

The problem

Where a brand icon set includes regular and dark icons, but no hDPI versions, I expect dark_icon.png to be served when dark_icon@2x.png is requested but instead icon.png is served. This can be observed when viewing an integration page in home assistant while in dark mode (which requests the hDPI version).

This seems like incorrect logic, or a least is unexpected.

e.g.

dave@morty:/tmp$ curl -s https://brands.home-assistant.io/oasissmart/icon.png | md5sum
c504c9e7e8c3e06fa212341104f53d45  -
dave@morty:/tmp$ curl -s https://brands.home-assistant.io/oasissmart/dark_icon.png | md5sum
e591847083bf49977c1cc81906b39aa2  -
dave@morty:/tmp$ curl -s https://brands.home-assistant.io/oasissmart/dark_icon@2x.png | md5sum
c504c9e7e8c3e06fa212341104f53d45  -

Additional information

Correctly rendered (dark_icon.png) in integrations page:

Image

Unexpectedly rendered icon.png as substitution for dark_icon@2x.png:

Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions