Getting Array to string conversion error on Php 7

[frogydiak]

On line# 293 of /plugins/system/plugin_googlemap3/plugin_googlemap3_helper.php:

this->_mp->$values[0]

causes Notice: Array to string conversion but if I modify the code to:

$key = $values[0]; $this->_mp->{$key} = $values[1];

the Notice goes away.

[dautrich]

I've successfully tested this patch both under PHP 5.6.x and PHP 7.0.x.
I propose to use the patch in the next release of Google Maps Plugin.

[coolcat-creations]

thanks that helped!

[dautrich]

You're welcome!

[thexmanxyz]

Fixed my width:100% overwrite issue too. Really thx!

[dautrich]

The issue has not been fixed in version 3.4 of the plugin. The line number to apply the patch has changed to line 301.
With that patch, I have successfully tested the new plugin version under PHP7.

[thexmanxyz]

Can also confirm that applying the patch at line 301 in Version 3.4 does fix the problem again. 3.4 by default still contains the issue.

[abergo]

Try curly brackets. this->_mp->{$values[0]}

[gorgonz]

(first) fix works. Maybe it should be mentioned, that "if" doesn't have curly braces here, so
this->_mp->$values[0]=$values[1];
should be replaced with
{ $key = $values[0]; $this->_mp->{$key} = $values[1]; }

[thexmanxyz]

New Revision is out 3.5 (i think). But the problem still persists in 3.5 and has not been fixed. The proposed fix from above still works ;). Just to let you all know :P

[GeraldST]

I guess developer has left the building ... the two pending pull requests #28 and #25 helped me a lot. Sadly they haven't got a commit for quite some time.

[dautrich]

It was Mike Reumer's extension, but for whatever reason he has left and handed over to somebody else. The new team (?) obviously tried to make some money for support services, but seems to lack the experience to run a project like this. It's a shame!
For me the extension was the very best map extension functionally, but the lack of support forced me to switch to Phoca Maps.

[Mushr0000m]

So the team will not give an update for that big issue ?

[dautrich]

The issue is pending for more than one year now. Any questions?