Skip to content

Support filter by status #14891

@schogges

Description

@schogges

Description

It's often times useful to filter by status of dataplanes.

This currently doesn't work well because the filter doesn't act on insights.

list, err = r.MergeInOverview(list, insights)

We do filter well on insights:

if err := r.resManager.List(request.Request.Context(), insights, store.ListByMesh(meshName), store.ListByNameContains(nameContains), store.ListByFilterFunc(filter)); err != nil {

But we merge with the assumption that the resource list is the source of truth:

items := r.descriptor.NewOverviewList()

So there's a few ways to go about:

  1. Don't include resources when they don't have insights.

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/featureNew featuretriage/acceptedThe issue was reviewed and is complete enough to start working on it

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions