Skip to content

[Vendor] [Quality Mngmnt] - Calling Insert/Modify/Delete with then #5819

@PredragMaricic

Description

@PredragMaricic

Describe the issue

Using this pattern risks silent failures, which can introduce inconsistencies or other bugs when used as part of a larger process.

Image

Examples:
QltyGenerationRuleMgmt.Codeunit.al 227,60: if TemporaryTestMatchRecordRef.Insert(false) then; 265,79: if TempAlreadySearchedsQltyInspectSourceConfig.Insert() then; 314,56: if TempQltyInTestGenerationRule.Insert() then;
QltyInTestGenerationRule.Table.al 319,27: if Rec.Insert() then;
QltyInTestGeneratRules.Page.al 663,56: if QltyInTestGenerationRule.Modify() then;
QltyGradeEvaluation.Codeunit.al 262,64: if OptionalQltyInspectionTestHeader.Modify(true) then; 551,60: if TempNumericalQltyInspectionTestLine.Insert(false) then; 702,48: if TempTestStringValueQltyField.Insert() then;
QltyTraversal.Codeunit.al 217,52: if TemporaryTestMatchRecordRef.Insert(false) then;
QltyField.Table.al 527,60: if TempBufferQltyLookupCode.Insert() then;
QltyFieldExprCardPart.Page.al 505,33: if QltyField.Insert() then;
QltyFieldNumberCardPart.Page.al 1040,33: if QltyField.Insert() then;
QltyFieldWizard.Page.al 348,49: if QltyField.Delete() then;
QltyLookupCodePart.Page.al 406,37: if QltyField.Modify(true) then; 506,33: if QltyField.Insert() then;
QltyDispMoveWorksheet.Codeunit.al 169,49: if TempCreatedsWhseWorksheetLine.Insert() then;
QltyDispPurchaseReturn.Codeunit.al 156,51: if TempCreatedBufferPurchaseHeader.Insert() then;
QltyDispInternalPutAway.Codeunit.al 151,43: if WhseInternalPutAwayLine.Modify() then;
QltyInspectionTestHeader.Table.al 350,40: if Rec.Modify(false) then; 356,44: if Rec.Modify(false) then; 1191,31: if Rec.Modify() then; 1255,31: if Rec.Modify() then; 1315,31: if Rec.Modify() then;
QltyProdGenRuleWizard.Page.al 815,44: if QltyManagementSetup.Modify(false) then;
QltyProductionIntegration.Codeunit.al 405,49: if QltyInspectionTestHeader.Modify(false) then; 425,49: if QltyInspectionTestHeader.Modify(false) then; 445,49: if QltyInspectionTestHeader.Modify(false) then;
QltyRecGenRuleWizard.Page.al 927,44: if QltyManagementSetup.Modify(false) then;
QltyWarehouseIntegration.Codeunit.al 67,50: if TempTrackingSpecification.Insert(false) then; 157,56: if TempOutTrackingSpecification.Insert() then;
QltyWhseGenRuleWizard.Page.al 681,44: if QltyManagementSetup.Modify(false) then;
QltyInventoryAvailability.Codeunit.al 78,54: if TempOutBinContent.Insert(false) then; 97,54: if TempOutBinContent.Insert(false) then;
QltyReportSelection.Page.al 94,27: if Rec.Modify() then;
QltyInspectionActivities.Page.al 65,27: if Rec.Insert() then;
QltyMiscHelpers.Codeunit.al 296,56: if TempBufferQltyLookupCode.Insert() then;
QltyNotificationMgmt.Codeunit.al 406,52: if QltyInspectionTestHeader.Modify() then;

Expected behavior

Steps to reproduce

Additional context

I will provide a fix for a bug

  • I will provide a fix for a bug

Metadata

Metadata

Assignees

No one assigned

    Labels

    ApprovedThe issue is approvedSCMGitHub request for SCM area

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions