Skip to content

Commit 32c5db0

Browse files
andreyneringmvdan
authored andcommitted
moreinterp: update u-root and remove test workarounds
Ref u-root/u-root#3437
1 parent 7ad4e43 commit 32c5db0

File tree

4 files changed

+12
-25
lines changed

4 files changed

+12
-25
lines changed

moreinterp/coreutils/coreutils.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,9 @@ var commandBuilders = map[string]func() core.Command{
4444
"touch": func() core.Command { return touch.New() },
4545
"xargs": func() core.Command { return xargs.New() },
4646
"base64": func() core.Command { return base64.New() },
47-
"gzip": func() core.Command { return gzip.New() },
47+
"gzcat": func() core.Command { return gzip.New("gzcat") },
48+
"gzip": func() core.Command { return gzip.New("gzip") },
49+
"gunzip": func() core.Command { return gzip.New("gunzip") },
4850
"mktemp": func() core.Command { return mktemp.New() },
4951
"shasum": func() core.Command { return shasum.New() },
5052
"tar": func() core.Command { return tar.New() },

moreinterp/coreutils/coreutils_test.go

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -39,21 +39,6 @@ func TestExecHandler(t *testing.T) {
3939
t.Fatalf("expected error for command %q, got none", cmd)
4040
}
4141

42-
// FIXME(@andreynering): Return the proper flag error from u-root to
43-
// avoid a special tests for chmod and gzip.
44-
if coreUtil == "chmod" {
45-
if err.Error() != "chmod: chmod [mode] filepath" {
46-
t.Errorf("expected %q output, got: %q", cmd, err)
47-
}
48-
return
49-
}
50-
if coreUtil == "gzip" {
51-
if err.Error() != "gzip: ignoring stdout, use -f to compression" {
52-
t.Errorf("expected %q output, got: %q", cmd, err)
53-
}
54-
return
55-
}
56-
5742
if !strings.Contains(err.Error(), "flag provided but not defined: -badoption") {
5843
t.Errorf("expected error for command %q, got: %v", cmd, err)
5944
}

moreinterp/go.mod

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ module mvdan.cc/sh/moreinterp
33
go 1.24.0
44

55
require (
6-
github.com/u-root/u-root v0.15.1-0.20251014130006-62f7144b33da
6+
github.com/u-root/u-root v0.15.1-0.20251208185023-2f8c7e763cf8
77
mvdan.cc/sh/v3 v3.11.0
88
)
99

@@ -13,6 +13,6 @@ require (
1313
github.com/klauspost/pgzip v1.2.6 // indirect
1414
github.com/pierrec/lz4/v4 v4.1.22 // indirect
1515
github.com/u-root/uio v0.0.0-20240224005618-d2acac8f3701 // indirect
16-
golang.org/x/sys v0.33.0 // indirect
17-
golang.org/x/term v0.32.0 // indirect
16+
golang.org/x/sys v0.38.0 // indirect
17+
golang.org/x/term v0.37.0 // indirect
1818
)

moreinterp/go.sum

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,13 @@ github.com/pierrec/lz4/v4 v4.1.22 h1:cKFw6uJDK+/gfw5BcDL0JL5aBsAFdsIT18eRtLj7VIU
1818
github.com/pierrec/lz4/v4 v4.1.22/go.mod h1:gZWDp/Ze/IJXGXf23ltt2EXimqmTUXEy0GFuRQyBid4=
1919
github.com/rogpeppe/go-internal v1.14.1 h1:UQB4HGPB6osV0SQTLymcB4TgvyWu6ZyliaW0tI/otEQ=
2020
github.com/rogpeppe/go-internal v1.14.1/go.mod h1:MaRKkUm5W0goXpeCfT7UZI6fk/L7L7so1lCWt35ZSgc=
21-
github.com/u-root/u-root v0.15.1-0.20251014130006-62f7144b33da h1:Vst9Tvq3G6f6pYBvxy7coi2arDsnOZ3Mkj8MkNarSK8=
22-
github.com/u-root/u-root v0.15.1-0.20251014130006-62f7144b33da/go.mod h1:R49zft13memK20EgFAvmTbXBS0t29UvglnM0BCA1ldQ=
21+
github.com/u-root/u-root v0.15.1-0.20251208185023-2f8c7e763cf8 h1:cq+DjLAjz3ZPwh0+G571O/jMH0c0DzReDPLjQGL2/BA=
22+
github.com/u-root/u-root v0.15.1-0.20251208185023-2f8c7e763cf8/go.mod h1:JNauIV2zopCBv/6o+umxcT3bKe8YUqYJaTZQYSYpKss=
2323
github.com/u-root/uio v0.0.0-20240224005618-d2acac8f3701 h1:pyC9PaHYZFgEKFdlp3G8RaCKgVpHZnecvArXvPXcFkM=
2424
github.com/u-root/uio v0.0.0-20240224005618-d2acac8f3701/go.mod h1:P3a5rG4X7tI17Nn3aOIAYr5HbIMukwXG0urG0WuL8OA=
25-
golang.org/x/sys v0.33.0 h1:q3i8TbbEz+JRD9ywIRlyRAQbM0qF7hu24q3teo2hbuw=
26-
golang.org/x/sys v0.33.0/go.mod h1:BJP2sWEmIv4KK5OTEluFJCKSidICx8ciO85XgH3Ak8k=
27-
golang.org/x/term v0.32.0 h1:DR4lr0TjUs3epypdhTOkMmuF5CDFJ/8pOnbzMZPQ7bg=
28-
golang.org/x/term v0.32.0/go.mod h1:uZG1FhGx848Sqfsq4/DlJr3xGGsYMu/L5GW4abiaEPQ=
25+
golang.org/x/sys v0.38.0 h1:3yZWxaJjBmCWXqhN1qh02AkOnCQ1poK6oF+a7xWL6Gc=
26+
golang.org/x/sys v0.38.0/go.mod h1:OgkHotnGiDImocRcuBABYBEXf8A9a87e/uXjp9XT3ks=
27+
golang.org/x/term v0.37.0 h1:8EGAD0qCmHYZg6J17DvsMy9/wJ7/D/4pV/wfnld5lTU=
28+
golang.org/x/term v0.37.0/go.mod h1:5pB4lxRNYYVZuTLmy8oR2BH8dflOR+IbTYFD8fi3254=
2929
mvdan.cc/sh/v3 v3.11.0 h1:q5h+XMDRfUGUedCqFFsjoFjrhwf2Mvtt1rkMvVz0blw=
3030
mvdan.cc/sh/v3 v3.11.0/go.mod h1:LRM+1NjoYCzuq/WZ6y44x14YNAI0NK7FLPeQSaFagGg=

0 commit comments

Comments
 (0)