-
-
Notifications
You must be signed in to change notification settings - Fork 292
Open
Labels
1. to developAccepted and waiting to be taken care of (should be only set by nextcloud employees)Accepted and waiting to be taken care of (should be only set by nextcloud employees)bugSomething isn't workingSomething isn't working
Description
The ContactsViewModel is currently retrieving users on object creation
init {
getContactsFromSearchParams()
}
which isn't inherently bad, but when used with our dependency injection setup, each @Inject creates a new instance of the class, which means that unnecessary network calls are made with entering activities that may rely on the functions exposed through the view model, but are not immediately requiring the entire contacts list of the user.
Metadata
Metadata
Assignees
Labels
1. to developAccepted and waiting to be taken care of (should be only set by nextcloud employees)Accepted and waiting to be taken care of (should be only set by nextcloud employees)bugSomething isn't workingSomething isn't working