Set-item is not overwriting the existing key

[vasanth62]

Hi Rob,

I came across this repo via stackoverflow. I was trying to use it, however noticed an issue where the existing keys are not overwritten. The below diff fixes it.

*************** class RandomDict(MutableMapping):
*** 20,30 ****
      def __setitem__(self, key, val):
          if key in self.keys:
              i = self.keys[key]
          else:
              self.last_index += 1
              i = self.last_index

-         self.values.append((key, val))
          self.keys[key] = i

      def __delitem__(self, key):
--- 28,39 ----
      def __setitem__(self, key, val):
          if key in self.keys:
              i = self.keys[key]
+             self.values[i] = (key, val)
          else:
              self.last_index += 1
              i = self.last_index
+             self.values.append((key, val))

          self.keys[key] = i

      def __delitem__(self, key):

Edit: Formatting

[bokanyie]

This was my problem, too! Thank you @NicoDeGiacomo for the fix.

[emeryberger]

This has been fixed and can be closed.