Skip to content

Commit f27d017

Browse files
committed
test: don't use needless eval
1 parent 564b85e commit f27d017

File tree

1 file changed

+12
-9
lines changed

1 file changed

+12
-9
lines changed

test/test_parser.rb

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,13 @@
11
# frozen_string_literal: false
22
require 'test/unit'
3+
require 'xmlrpc/create'
34
require 'xmlrpc/datetime'
4-
require "xmlrpc/parser"
5+
require 'xmlrpc/parser'
56
require 'yaml'
67

8+
# This must be required after xmlrpc/create and xmlrpc/parser.
9+
require 'xmlrpc/config'
10+
711
module GenericParserTest
812
def datafile(base)
913
File.join(File.dirname(__FILE__), "data", base)
@@ -84,14 +88,13 @@ def test_fault_message
8488
klass = parser.class
8589
name = klass.to_s.split("::").last
8690

87-
eval %{
88-
class Test_#{name} < Test::Unit::TestCase
89-
include GenericParserTest
91+
test_class = Class.new(Test::Unit::TestCase) do
92+
include GenericParserTest
9093

91-
def setup
92-
super
93-
@p = #{klass}.new
94-
end
94+
define_method(:setup_parser) do
95+
@p = klass.new
9596
end
96-
}
97+
setup :setup_parser
98+
end
99+
self.class.const_set("Test#{name}", test_class)
97100
end

0 commit comments

Comments
 (0)