Skip to content

Commit fd77df5

Browse files
committed
style: sonarqube issues
Signed-off-by: Thibault Meyer <meyer.thibault@gmail.com>
1 parent 7be8bcf commit fd77df5

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

src/main/java/io/github/thibaultmeyer/cuid/CUID.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,9 @@ public static boolean isValid(final String cuidAsString) {
119119
&& (cuidAsString.length() == CUIDv1.LENGTH_STANDARD && cuidAsString.startsWith(CUIDv1.START_CHARACTER) // Version 1
120120
|| (!cuidAsString.isEmpty())) // Version 2
121121
&& cuidAsString.chars()
122-
.filter(c -> !((c >= '0' && c <= '9') || (c >= 'A' && c <= 'Z') || (c >= 'a' && c <= 'z'))).findAny().isEmpty();
122+
.filter(c -> !((c >= '0' && c <= '9') || (c >= 'A' && c <= 'Z') || (c >= 'a' && c <= 'z')))
123+
.findAny()
124+
.isEmpty();
123125
}
124126

125127
/**

src/test/java/io/github/thibaultmeyer/cuid/HistogramTest.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package io.github.thibaultmeyer.cuid;
22

3+
import org.junit.jupiter.api.Assertions;
34
import org.junit.jupiter.api.MethodOrderer;
45
import org.junit.jupiter.api.Test;
56
import org.junit.jupiter.api.TestMethodOrder;
@@ -30,6 +31,7 @@ void histogramCUIDv1() {
3031
final Map<Integer, Integer> frequencies = histogram.histogram(20);
3132

3233
// Assert
34+
Assertions.assertNotNull(frequencies);
3335
System.out.println("CUID v1: " + frequencies);
3436
}
3537

@@ -48,6 +50,7 @@ void histogramCUIDv2() {
4850
final Map<Integer, Integer> frequencies = histogram.histogram(20);
4951

5052
// Assert
53+
Assertions.assertNotNull(frequencies);
5154
System.out.println("CUID v2: " + frequencies);
5255
}
5356

src/test/java/io/github/thibaultmeyer/cuid/PerformanceTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
final class PerformanceTest {
1515

1616
@BeforeAll
17-
public static void beforeAll() {
17+
static void beforeAll() {
1818

1919
System.gc();
2020
}

0 commit comments

Comments
 (0)