From ee733792f791bb3d4204f4712b41cf5afc11101a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jind=C5=99ich=20B=C3=A4r?= Date: Mon, 29 Dec 2025 14:25:21 +0100 Subject: [PATCH] chore(ci): fix assertions in e2e tests (#3316) Changes from #3267 change the web layout on crawlee.dev and broke the selectors in multiple e2e tests. This PR updates these selectors to match the current state of the web. This also pins the @types/node dependency in TS E2E tests to ^24.0.0. --- test/e2e/cheerio-curl-impersonate-ts/actor/package.json | 3 ++- test/e2e/cheerio-default-ts/actor/package.json | 3 ++- test/e2e/cheerio-impit-ts/actor/package.json | 3 ++- test/e2e/cheerio-max-requests/actor/main.js | 4 ++-- test/e2e/cheerio-page-info/actor/main.js | 4 ++-- test/e2e/cheerio-stop-resume-ts/actor/package.json | 3 ++- test/e2e/jsdom-default-ts/actor/package.json | 3 ++- test/e2e/jsdom-react-ts/actor/package.json | 3 ++- test/e2e/linkedom-default-ts/actor/package.json | 3 ++- test/e2e/puppeteer-page-info/actor/main.js | 4 ++-- 10 files changed, 20 insertions(+), 13 deletions(-) diff --git a/test/e2e/cheerio-curl-impersonate-ts/actor/package.json b/test/e2e/cheerio-curl-impersonate-ts/actor/package.json index 8e788a918600..14e060bc88a6 100644 --- a/test/e2e/cheerio-curl-impersonate-ts/actor/package.json +++ b/test/e2e/cheerio-curl-impersonate-ts/actor/package.json @@ -24,7 +24,8 @@ }, "devDependencies": { "@apify/tsconfig": "^0.1.0", - "typescript": "^5.0.0" + "typescript": "^5.0.0", + "@types/node": "^24.0.0" }, "scripts": { "start": "tsc && node main.js", diff --git a/test/e2e/cheerio-default-ts/actor/package.json b/test/e2e/cheerio-default-ts/actor/package.json index d0dfc7875eca..ec751d48268b 100644 --- a/test/e2e/cheerio-default-ts/actor/package.json +++ b/test/e2e/cheerio-default-ts/actor/package.json @@ -23,7 +23,8 @@ }, "devDependencies": { "@apify/tsconfig": "^0.1.0", - "typescript": "^5.0.0" + "typescript": "^5.0.0", + "@types/node": "^24.0.0" }, "scripts": { "start": "tsc && node main.js", diff --git a/test/e2e/cheerio-impit-ts/actor/package.json b/test/e2e/cheerio-impit-ts/actor/package.json index 03ccac5e739f..95895410f00d 100644 --- a/test/e2e/cheerio-impit-ts/actor/package.json +++ b/test/e2e/cheerio-impit-ts/actor/package.json @@ -24,7 +24,8 @@ }, "devDependencies": { "@apify/tsconfig": "^0.1.0", - "typescript": "^5.0.0" + "typescript": "^5.0.0", + "@types/node": "^24.0.0" }, "scripts": { "start": "tsc && node main.js", diff --git a/test/e2e/cheerio-max-requests/actor/main.js b/test/e2e/cheerio-max-requests/actor/main.js index dbf711ff38e3..68c1c1b1127f 100644 --- a/test/e2e/cheerio-max-requests/actor/main.js +++ b/test/e2e/cheerio-max-requests/actor/main.js @@ -34,8 +34,8 @@ await Actor.main(async () => { } } else if (label === 'DETAIL') { const uniqueIdentifier = url.split('/').slice(-2).join('/'); - const title = $('header h1').text(); - const firstParagraph = $('header + p').text(); + const title = $('.markdown h1').text(); + const firstParagraph = $('.markdown > p').text(); const modifiedDate = $('.theme-last-updated time').attr('datetime'); await Dataset.pushData({ diff --git a/test/e2e/cheerio-page-info/actor/main.js b/test/e2e/cheerio-page-info/actor/main.js index fbc87f3c425b..ccb3a1762d55 100644 --- a/test/e2e/cheerio-page-info/actor/main.js +++ b/test/e2e/cheerio-page-info/actor/main.js @@ -22,8 +22,8 @@ router.addHandler('DETAIL', async ({ request, $ }) => { const { url } = request; const uniqueIdentifier = url.split('/').slice(-2).join('/'); - const title = $('header h1').text(); - const firstParagraph = $('header + p').text(); + const title = $('.markdown h1').text(); + const firstParagraph = $('.markdown > p').text(); const modifiedDate = $('.theme-last-updated time').attr('datetime'); await Dataset.pushData({ diff --git a/test/e2e/cheerio-stop-resume-ts/actor/package.json b/test/e2e/cheerio-stop-resume-ts/actor/package.json index cf307b836523..cbfc00fd28d5 100644 --- a/test/e2e/cheerio-stop-resume-ts/actor/package.json +++ b/test/e2e/cheerio-stop-resume-ts/actor/package.json @@ -23,7 +23,8 @@ }, "devDependencies": { "@apify/tsconfig": "^0.1.0", - "typescript": "^5.0.0" + "typescript": "^5.0.0", + "@types/node": "^24.0.0" }, "scripts": { "start": "tsc && node main.js", diff --git a/test/e2e/jsdom-default-ts/actor/package.json b/test/e2e/jsdom-default-ts/actor/package.json index cefb319689d8..a565508ac4b4 100644 --- a/test/e2e/jsdom-default-ts/actor/package.json +++ b/test/e2e/jsdom-default-ts/actor/package.json @@ -23,7 +23,8 @@ }, "devDependencies": { "@apify/tsconfig": "^0.1.0", - "typescript": "^5.0.0" + "typescript": "^5.0.0", + "@types/node": "^24.0.0" }, "scripts": { "start": "tsc && node main.js", diff --git a/test/e2e/jsdom-react-ts/actor/package.json b/test/e2e/jsdom-react-ts/actor/package.json index b0479560ea63..c4712c32ce4f 100644 --- a/test/e2e/jsdom-react-ts/actor/package.json +++ b/test/e2e/jsdom-react-ts/actor/package.json @@ -23,7 +23,8 @@ }, "devDependencies": { "@apify/tsconfig": "^0.1.0", - "typescript": "^5.0.0" + "typescript": "^5.0.0", + "@types/node": "^24.0.0" }, "scripts": { "start": "tsc && node main.js", diff --git a/test/e2e/linkedom-default-ts/actor/package.json b/test/e2e/linkedom-default-ts/actor/package.json index 04796ca89000..c588037071cf 100644 --- a/test/e2e/linkedom-default-ts/actor/package.json +++ b/test/e2e/linkedom-default-ts/actor/package.json @@ -23,7 +23,8 @@ }, "devDependencies": { "@apify/tsconfig": "^0.1.0", - "typescript": "^5.0.0" + "typescript": "^5.0.0", + "@types/node": "^24.0.0" }, "scripts": { "start": "tsc && node main.js", diff --git a/test/e2e/puppeteer-page-info/actor/main.js b/test/e2e/puppeteer-page-info/actor/main.js index 88fd1b9d8f60..495d361605de 100644 --- a/test/e2e/puppeteer-page-info/actor/main.js +++ b/test/e2e/puppeteer-page-info/actor/main.js @@ -33,8 +33,8 @@ await Actor.main(async () => { const uniqueIdentifier = url.split('/').slice(-2).join('/'); - const titleP = page.$eval('header h1', (el) => el.textContent); - const firstParagraphP = page.$eval('header + p', (el) => el.textContent); + const titleP = page.$eval('.markdown h1', (el) => el.textContent); + const firstParagraphP = page.$eval('.markdown > p', (el) => el.textContent); const modifiedDateP = page.$eval('.theme-last-updated time', (el) => el.getAttribute('datetime')); const [title, description, modifiedDate] = await Promise.all([titleP, firstParagraphP, modifiedDateP]);