Software crashed when I run vsgExamples/examples/commands/vsgexecutecommands #1663
-
|
When I run the 'vsgexecutecommands' example, the software crashes. |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment
-
|
I have reproduce the crash on my system with VSG/vsgExamples master and created a Issue for this bug. I then investigated the issue and found the regression was caused by the SecondaryCommandGraph's connection of the CommandBuffer and State objects not handling the addition of lazy state updating that was add to State. When I added the lazy state updating support (for performance reasons) I modified the the CommandGraph implementation uses the new State::connect(commandBuffer) function but missed updating the similar SecondaryCommandGraph code to use these new method. This meant that CommandBuffer and State objects that needed to be connected in a particular way The fix ended up being very simply - just replacing the pointer assignment with a State::connect(..) call, this fix is now merged with VSG master and will be part of the up coming 1.1.14 release that I'll make later this week. |
Beta Was this translation helpful? Give feedback.
I have reproduce the crash on my system with VSG/vsgExamples master and created a Issue for this bug.
I then investigated the issue and found the regression was caused by the SecondaryCommandGraph's connection of the CommandBuffer and State objects not handling the addition of lazy state updating that was add to State.
When I added the lazy state updating support (for performance reasons) I modified the the CommandGraph implementation uses the new State::connect(commandBuffer) function but missed updating the similar SecondaryCommandGraph code to use these new method. This meant that CommandBuffer and State objects that needed to be connected in a particular way
The fix ended up being ver…