Commit c23aec1
authored
Report all hostname state failures for URLPattern
URLPattern's canonicalize a hostname is the only invocation of the basic URL parser with a URL and state override set to hostname state that looks at the return failure.
And since the URL that URLPattern uses is a dummy URL that is ideally not exposed, knowing about all the failure conditions is kind of important.
(Now technically the second return failure added here cannot be observed as the dummy URL won't have credentials or a non-null port, but it seemed good to change that at the same time for consistency.)
This is covered by existing URLPattern web-platform-tests. Some more background can be found in whatwg/urlpattern#252.1 parent 6c78200 commit c23aec1
1 file changed
+5
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2538 | 2538 | | |
2539 | 2539 | | |
2540 | 2540 | | |
2541 | | - | |
| 2541 | + | |
2542 | 2542 | | |
2543 | 2543 | | |
2544 | 2544 | | |
2545 | 2545 | | |
2546 | 2546 | | |
2547 | 2547 | | |
2548 | 2548 | | |
2549 | | - | |
| 2549 | + | |
| 2550 | + | |
2550 | 2551 | | |
2551 | 2552 | | |
2552 | 2553 | | |
| |||
2566 | 2567 | | |
2567 | 2568 | | |
2568 | 2569 | | |
2569 | | - | |
| 2570 | + | |
2570 | 2571 | | |
2571 | 2572 | | |
2572 | 2573 | | |
| |||
2576 | 2577 | | |
2577 | 2578 | | |
2578 | 2579 | | |
2579 | | - | |
| 2580 | + | |
2580 | 2581 | | |
2581 | 2582 | | |
2582 | 2583 | | |
| |||
0 commit comments