Support OS 26.0 #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces compatibility updates for iOS 26+ along with visual design refinements. Key changes include:
- Enhancing GlassBackgroundModifier with conditional application of the new glassEffect API.
- Updating the _BlankTemplate view to use a ZStack with a gradient background and bold text.
- Adjusting the navigation button styling in Buttons.swift to selectively apply effects based on OS version.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Sources/SwiftGlass/GlassBackgroundModifier.swift | Enhanced view modifier with conditional glassEffect and shadow for iOS 26+ |
| Demo/Demo/Samples/_BlankTemplate.swift | Updated layout to use ZStack with gradient background and bold text styling |
| Demo/Demo/Samples/Essential/Buttons.swift | Added conditional branches for button styling to support updated navigation designs |
Comments suppressed due to low confidence (1)
Demo/Demo/Samples/_BlankTemplate.swift:15
- [nitpick] Verify that the inclusion of the Apple logo character in the greeting text is intentional and aligns with the project's branding guidelines.
Text("Hello, Developer!")
Add macOS 26 and Xcode 26
Owner
Author
|
Skip workflow as not available |
|
hi! out of curiosity, why does this require Swift 6? https://github.com/1998code/SwiftGlass/releases/tag/1.9.9 |
Owner
Author
|
@benguild Hi, this issue has been resolved in the latest version :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces compatibility updates for iOS 26 and other platforms, refines the visual design of components, and enhances the
GlassBackgroundModifierfor better rendering effects. The changes ensure backward compatibility while leveraging new APIs where available.Compatibility updates for iOS 26 and other platforms:
Demo/Demo/Samples/Essential/Buttons.swift: Added conditional logic to use updated button styles and effects for iOS 26 and newer platforms. For older versions, the previous styles are retained. [1] [2] [3]Sources/SwiftGlass/GlassBackgroundModifier.swift: Enhanced theGlassBackgroundModifierto applyglassEffectfor iOS 26 and newer platforms, ensuring improved rendering while maintaining compatibility with older versions. [1] [2]Visual design improvements:
Demo/Demo/Samples/_BlankTemplate.swift: Updated the_BlankTemplateview to use aZStacklayout with a gradient background (bg) for a more polished appearance. The text styling was also adjusted to include bold formatting.