-
-
Notifications
You must be signed in to change notification settings - Fork 9
6.0 Enhancement #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6.0 Enhancement #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the README.md to improve clarity, update content, and reorganize sections following the project rename.
- Renames project from SwiftNEWKit to SwiftNEW and updates related references.
- Refreshes the features table, preview/gallery sections, and reorganizes platform compatibility.
- Introduces a new Contributing section while removing outdated FAQ and developer notes.
Comments suppressed due to low confidence (3)
README.md:41
- Badge URLs still reference the old
SwiftNEWKitrepository. Update the paths toSwiftNEWto ensure the badges display correctly.

README.md:6
- [nitpick] The table header
Descriptionis generic. Consider renaming it toFeatureorFeature Descriptionfor clarity.
| Description | Version |
README.md:71
- [nitpick] The instruction
Import Package.is ambiguous; change it to something likeImport the SwiftNEW package.
1. Import Package.
|
This pull request introduces several updates to the Deployment Target and Platform Updates:
Dependency Updates:
Code Simplifications and Feature Enhancements:
Data and Documentation Updates:
These changes collectively modernize the project, improve maintainability, and enhance the user experience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request primarily refactors the project’s README documentation, updates project naming and features, and revises various code components in the SwiftNEW module and demo application to align with new platform naming (visionOS) and API improvements (e.g. introducing SwiftGlass). Key updates include:
- Renaming “SwiftNEWKit” to “SwiftNEW” and reorganizing README sections.
- Updating conditional compilation directives and UI modifiers in SwiftNEW.swift to support visionOS, along with adding the SwiftGlass dependency.
- Revamping demo project files (JSON localization files, preview code, and Xcode project settings) and adding a new GitHub workflow for JSON schema validation.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Sources/SwiftNEW/SwiftNEW.swift | Updated conditional directives from xrOS to visionOS and applied consistent glass UI modifiers. |
| README.md | Refactored project title, features table, image assets, and documentation organization. |
| Package.swift | Updated platform versions and replaced the custom xros platform with visionOS; added SwiftGlass. |
| Demo/What's New?/zh-Hant.lproj/data.json, zh-Hans.lproj/data.json, en.lproj/data.json | Updated version numbers and content for localization files. |
| Demo/What's New?/What_s_New_App.swift | Temporarily replaced ContentView with a simple demo Text view. |
| Demo/What's New?/ContentView.swift | Adopted new preview macros and removed legacy code sections for a cleaner demo interface. |
| Demo/What's New?.xcodeproj/{project.xcworkspace/Package.resolved, project.pbxproj} | Adjusted deployment targets and version metadata to align with the new release. |
| .github/workflows/validate-json.yml | Added a GitHub workflow for JSON syntax and schema validation across localization files. |
|
This pull request introduces a variety of changes, including the addition of a GitHub Actions workflow for validating JSON files, updates to project configuration files, dependency updates, and modifications to localized JSON data. Below is a summary of the most important changes grouped by theme: Workflow Automation
Project Configuration Updates
Dependency Management
Code Changes
Localization Updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request updates the project’s branding and documentation while refining the SwiftNEW source code and package configuration. Key changes include renaming the project and updating README content (with translations), refactoring UI code in SwiftNEW (including updating preprocessor directives and adding the SwiftGlass dependency), and modifying Package.swift and demo files for improved platform compatibility and demo presentation.
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/SwiftNEWTests/SwiftNEWTests.swift | Test file removed, potentially affecting automated test coverage. |
| Sources/SwiftNEW/SwiftNEW.swift | Updates to conditional compilation for visionOS, added SwiftGlass usage, and minor logic improvements. |
| README files (various languages) | Reorganization and updated documentation content and language-specific translations. |
| Package.swift | Updated platform versions and added SwiftGlass dependency. |
| Demo/* | Adjustments in demo files including data.json updates and simplified ContentView previews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances SwiftNEW to version 6.0 by renaming the project, reorganizing documentation, adding SwiftGlass and visionOS support, and updating demo content.
- Renamed SwiftNEWKit to SwiftNEW, restructured README and localized docs (features, examples, compatibility, contributing).
- Integrated SwiftGlass dependency, replaced xrOS flags with visionOS, and applied
.glassmodifiers in SwiftNEW view. - Removed the outdated test file and updated demo JSON entries for version 6.0 and 5.5 across all locales.
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/SwiftNEWTests/SwiftNEWTests.swift | Removed outdated test scaffold |
| Sources/SwiftNEW/SwiftNEW.swift | Added import SwiftGlass, updated visionOS flags and modifiers |
| Package.swift | Bumped macOS platform, replaced xros with visionOS, added SwiftGlass dependency |
| Demo/What's New?/en.lproj/data.json (and other locales) | Inserted new version entries for 6.0 and 5.5 |
| README.md & README/* | Renamed project, reorganized sections, updated usage and contributing |
| Demo/What's New?.xcodeproj/project.pbxproj | Updated deployment targets, marketing and project versions, added XROS setting |
| Demo/What's New?.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved | Pinned SwiftGlass package |
| .github/workflows/validate-json.yml | Added JSON schema and localization completeness validation |
Comments suppressed due to low confidence (2)
Tests/SwiftNEWTests/SwiftNEWTests.swift:6
- The entire test file was removed, eliminating any existing test coverage for SwiftNEW. Consider adding or updating unit tests to cover the new functionality and ensure ongoing reliability.
-import XCTest
Demo/What's New?.xcodeproj/project.pbxproj:310
- [nitpick]
CURRENT_PROJECT_VERSIONis set to 15 whileMARKETING_VERSIONis 6.0; ensure the build number and marketing version follow your versioning scheme or adjust for clarity.
CURRENT_PROJECT_VERSION = 15;
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
This pull request introduces several significant updates, including the addition of a GitHub Actions workflow for JSON validation, project configuration updates, dependency changes, and content updates for localized JSON files. Below is a breakdown of the most important changes: Automation and Validation
Project Configuration Updates
Dependency Management
Code Simplification
Localization Updates |
|
This pull request introduces significant updates to the project, including the addition of a GitHub Actions workflow for JSON validation, updates to the Xcode project configuration to support additional languages and platforms, and improvements to the Workflow Automation
Xcode Project Updates
Dependency Management
Codebase Simplification
Data File Updates |
|
This pull request introduces significant updates to the project, including a new GitHub Actions workflow for validating JSON files, updates to the Xcode project configuration, and content changes in the JSON Validation and Localization Workflow:
Xcode Project Configuration Updates:
Dependency Management:
Content Updates in
|
This pull request updates the
README.mdfile to improve clarity, update content, and reorganize sections. Key changes include renaming the project, updating features and examples, reorganizing platform compatibility details, and revising the contributing guidelines.Updates to Project and Features:
Reorganization of Examples and Compatibility:
Contributing and Documentation: