Add support for proxyprotocol for DoT #473
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
peterverraedt
force-pushed
the
master
branch
from
650f152 to
f2ba039
Compare
Author
|
/windsurf-review |
If the connection is made from one of the trusted proxies ip addresses, it is allowed that TCP and TLS connections contain a proxyprotocol header to pass source connection information. This in particular allows dns over tls behind a load balancer, while keeping source ip address information. Signed-off-by: Peter Verraedt <peter@verraedt.be>
peterverraedt
force-pushed
the
master
branch
from
f2ba039 to
8f35270
Compare
Author
|
/windsurf-review |
|
Thanks a lot for your work on this, @peterverraedt. Have you happened to look at the UDP support as well, and can you estimate how difficult it would be to implement? As far as I know, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the proxy protocol in TCP and TLS listeners, to allow Adguard to be placed behind a load balancer/proxy such as nginx or traefik. If the connection is made from one of the trusted proxies ip addresses, it is allowed - but not required - that TCP and TLS connections contain a proxy protocol header to pass source connection information. If a connection is made from other ip addresses, no proxy protocol header is allowed.
We don't allow proxy protocol in the HTTPS or QUIC listeners as there the source ip information can be passed by HTTP headers instead.
This fixes AdguardTeam/AdGuardHome#2798.