Admin users see user list and can adjust permissions #219
Conversation
1FoxInTheBox1
left a comment
1FoxInTheBox1
left a comment
There was a problem hiding this comment.
looking good, just a few questions
| id: string; | ||
| username: string; | ||
| name: string; | ||
| is_google: boolean; |
There was a problem hiding this comment.
Is there a reason we're only worried about google users? Like do we need an is_github field as well?
There was a problem hiding this comment.
This originally came from the idea that we would only use google and github, and so is_google implies the other. However, I could totally see that if we wanted to add more services we might want this to be a service: string field instead. I'll check with Rob to see if he thinks we might ever use more than those two
There was a problem hiding this comment.
It turns out that yes, he would like an offline login thing as well. I'll make changes to this in my next PR however, and this will work for now
|
|
||
| <div class="text-center py-4">User List WIP</div> | ||
| <div class="text-smfont-meduim"> | ||
| Default permission settings: |
There was a problem hiding this comment.
I wonder if there's a way to make these permissions settings configurable. Probably not hugely important, but it might be nice.
There was a problem hiding this comment.
There should be, as I can probably configure a thing with the mongodb and session stores. Worth asking Rob if this is a wanted feature, but will probably be in a follow up pr
There was a problem hiding this comment.
Rob said this should go in the backlog for now
rhit-maroisem
force-pushed
the
maroisem/admin-see-user-list
branch
from
9b0fad0 to
d911879
Compare
1FoxInTheBox1
left a comment
1FoxInTheBox1
left a comment
There was a problem hiding this comment.
LGTM!
Sounds like there's more work to be done but it's not directly related to this PR.
This PR adds the capability for admins to see a list of all registered users, and edit their permissions. These different permissions allow different levels of access, such as moving, editing, deleting, etc.