Update to 1.33 #18
Open
Update to 1.33 #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The overload of the `CrossfadeTo` method which allows specifying whether or not to use defaults is now private. Now we must use the other overload (which is public)
This is now needed for the `Systems.Collections.Generic.Queue<>` type name
This way, the file actually appears in Visual Studio and can be compiled
Turns out there's a better way to do this that doesn't involve adding `mscorlib`.
Closed
Add check for empty queue and skip attempt to call Dequeue if the queue is empty
Author
|
This also compiles for 1.34.0 successfully, although I haven't had a chance to test in-game yet (but 1.33 and 1.34 are very similar so I'm confident it will work fine) |
Author
|
I've been playing on 1.34.0 (and now 1.34.2) for several days now and I haven't run into any issues with it (in fact, I'm using the same |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #17, bringing compatibility all the way up to 1.33.