Profile UI for CCE Minor Experiences.

[seedyjahateh]

Issue Description

Fixes #1152

• We needed to create a new page where we could create Summer Experiences with all of the information CELTS needs instead of just one text box.

Changes

• Created a new tab system for navigating between Sustained Engagements, Summer Experience, and Other Engagements.
• Created a new form for submitting a Summer Experience.
• Created a new model for summerExperience.
• Fixed up and made the Request Other Engagement page accessible.
• Added phone number validation to the Company/Org part of the form.
• Modularized the HTML for reusability.
• Dynamically populated the years drop downs.
• Wrote tests for the new createSummerExperience function.

Testing

• After setting up environment and resetting the databases, run tests with ./tests/run_tests.sh
• Run the application using flask run.
• Click on the Minor Management tab in the Admin sidebar.
• Click on any of the names under the CCE Minor Progress table (we did most of our testing on Ebenezer Ayisi.
• Select the Summer Experience tab to open up the form.
• Check the styling and then fill out all the information and submit.
• Once kicked back to the Sustained Community Engagements page, return to Summer Experience and attempt to fill out the form but make sure to select Other for the 3rd to last question and no for the final question to verify the conditional check boxes are working.
• Check the database with mysql -u root -proot -> use celts -> select * from summerexperience; to make sure the data you just submitted is all there.
• Merge our PR :)

[BrianRamsay]

• No text in phone number field
• Supervisor phone and email should not be required
• Required fields should have the red * (we have that style from somewhere else)
• Summer experience should connect through the IndividualRequirement table for the minor. See: Admin minor management page
• No big duplicate chunks for read-only vs edit
• Use jquery everywhere instead of vanilla javascript

[bledsoef]

Ask for additional information for Community-Engaged Summer Experience

[Karina-Agliullova]

Profile UI for CCE Minor Experiences (PR)

[hoerstl]

Excellently executed PR! We've got some changes we'd like to request ranging from removing comments, refactoring code, and some rather major bug fixes we want you to take a look at. Overall, good work so far!

[hoerstl]

The function getSummerExperience in /home/vscode/celts/app/logic/minor.py has odd behavior and could use a new docstring or just a rework to what it does for clarity.

def getSummerExperience(username): seems like it would have odd behavior if a user has more than one summer experience and just return None, None. You should try to write some tests for this as there aren't any right now.

The docstring of the function definitely needs to be updated to describe what it returns (String name of the term, String name of the summer experience [e.x. "Internship: Jewish Vocational Service" - from prod backup])

[github-actions]

View Code Coverage

outdated