Skip to content

Conversation

@Kafui123
Copy link

@Kafui123 Kafui123 commented Nov 13, 2025

Summary of Changes

This update improves the Labor Status Form adjustment workflow by enhancing email communication and making adjustment details visible to users.

Key Changes

Added a new email template for labor status form adjustments, including a link for supervisors/students to review and add adjustment reasons.

Updated the adjustment form UI so users can now see which fields were changed compared to the original submitted form.

Fixed the issue where adjustment emails were previously empty — the email now correctly includes the message: “Labor Status Form Adjusted” along with the adjustment link.

How to Test

Switch to the 527StudentReasons branch

  • git checkout 527StudentReasons

Set Term:

  • first go to Administration > manage terms > click 2025-2026 and set primary forms due and adjustment due way in the future so that this allows the new labor status form to be created without restriction on hours assigned and allow term state to be open.

Create New Labor Status Form:
-Select supervisor, Department, Term that you just set, Start Date & End Date, Student and Position.

  • Click Review button and click submit.

Approve the form:

  • Go to Administration > Pending Forms > Pre-student Approval and select the form you want to approve and click Skip Student Approval for Selected Forms button. than click skip student approval in the modal
  • Then go to Pending Labor Status Forms select the form you want to approve and click Approve Selected Forms and click Approve Selected when the model popped up.

Make an Adjustment to the approved form:

  • Go to Supervisor Portal and select All Active Terms Department All Supervisor and All students and click all checkbox of limit form status, you will see as Approved the person you have submitted.
  • click their name and head to their labor history. Click their box and click the adjustment form.
  • and change whatever you want in the adjust labor status form like hours per week and add a note and submit changes

Check your email — you should now receive a populated adjustment email containing:

Subject: “Labor Status Form Adjusted”
Body: Dear Elaheh Jamali,

An adjustment has been made to your Labor Status Form by Scott Heggen.

Please follow the attached link to verify information needed for the approval of an adjusted form: http://localhost:5001/studentOverloadApp/6

Sincerely,
Labor Program Office
labor_program@berea.edu
859-985-3611

If the link is clicked you will be directed to:

(Previously, this email was blank.)

Expected Results:

Adjustment email is no longer empty.

The email includes the correct template and link.

The adjustment form clearly displays old vs. new values as well as an option for the student to add their reason for wanting an adjustment.

@ojmakinde ojmakinde linked an issue Nov 14, 2025 that may be closed by this pull request
Copy link
Contributor

@ojmakinde ojmakinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jonimz Jonimz requested a review from ojmakinde November 17, 2025 15:13
Copy link
Contributor

@ojmakinde ojmakinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the branch, created a new LSF, got the student to accept it, and while it was pending, I changed the number of hours to 20, triggering an overload. After doing that, an email was sent, and when I clicked the email link, I got this bug:

Image

This is also what the email looked like, just to ensure I was following the correct instructions:

Image

@ojmakinde
Copy link
Contributor

Also, why don't you put information regarding the overload in the email? It's a bit bland and doesn't provide any information about the role or what's being adjusted from first glance

@Kafui123
Copy link
Author

Also, why don't you put information regarding the overload in the email? It's a bit bland and doesn't provide any information about the role or what's being adjusted from first glance

This was how it was set up already... I just used the pre-existing template.

@Kafui123
Copy link
Author

I ran the branch, created a new LSF, got the student to accept it, and while it was pending, I changed the number of hours to 20, triggering an overload. After doing that, an email was sent, and when I clicked the email link, I got this bug:

Image This is also what the email looked like, just to ensure I was following the correct instructions: Image

I followed the steps you described above, but I did not get an error. Perhaps we can review it together tomorrow, if possible.

Comment on lines 98 to 102
if fieldName == "department":
oldDept = Department.get(Department.ORG == oldValue)
newDept = Department.get(Department.ORG == newValue)
oldValue = oldDept.DEPT_NAME
newValue = newDept.DEPT_NAME
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is strange. If we assume there can only be one adjusted field, then this department change would not lead to an overload. Since you're treating adjusted change like there's only one possible change, you're overwriting the old value and new value that I would assume to be the hours. This implementation is a bit strange and we should talk about it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still unresolved

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the adjusted change allows for multiple adjustments, not just one. Also, if the adjustment happens to be only the department then that will be treated as a regular adjustment and not an overload adjustment.

@Kafui123 Kafui123 requested a review from BrianRamsay December 6, 2025 00:10
@MImran2002
Copy link
Contributor

image when I typed it in the notes which is basically a change I believe it still doesn't detect the adjustment

@MImran2002 MImran2002 self-assigned this Dec 18, 2025
@MImran2002 MImran2002 self-requested a review December 18, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Student reasons don't show on adjustment forms

5 participants