app: Don't disable submit button on submission #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it is a good idea to prevent multiple submissions of the same content, disabling the submit button has a lot of negatives: * If the user's Internet connection is interrupted, and they click Submit, the user-agent will likely render a "Web page not available" message. When they go back, the user-agent may 'remember' the button being disabled and prevent the form from being submitted. * Screen readers cannot communicate the change in form availability without significantly more work (at least an aria-live container noting that the form has been submitted and cannot be interacted with any longer until the results are available). * For the search form, if the user notices a typo and tries to fix it before the results page loads, they cannot submit the fixed query. This commit removes the `data-disable-with` property from the five button elements that had it, thereby not disabling the button on form submission. Solving the duplicate submission issue is outside the scope of this ticket. Closes: ADA-396
anarchivist
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it is a good idea to prevent multiple submissions of the same content, disabling the submit button has a lot of negatives:
If the user's Internet connection is interrupted, and they click Submit, the user-agent will likely render a "Web page not available" message. When they go back, the user-agent may 'remember' the button being disabled and prevent the form from being submitted.
Screen readers cannot communicate the change in form availability without significantly more work (at least an aria-live container noting that the form has been submitted and cannot be interacted with any longer until the results are available).
For the search form, if the user notices a typo and tries to fix it before the results page loads, they cannot submit the fixed query.
This commit removes the
data-disable-withproperty from the five button elements that had it, thereby not disabling the button on form submission. Solving the duplicate submission issue is outside the scope of this ticket.Closes: ADA-396