Skip to content

Conversation

@ArgoZhang
Copy link
Member

Link issues

fixes #909

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Copilot AI review requested due to automatic review settings January 24, 2026 04:48
@bb-auto bb-auto bot added the enhancement New feature or request label Jan 24, 2026
@bb-auto bb-auto bot added this to the v9.2.0 milestone Jan 24, 2026
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @ArgoZhang, your pull request is larger than the review limit of 150000 diff characters

@ArgoZhang ArgoZhang merged commit ceb4c32 into master Jan 24, 2026
5 checks passed
@ArgoZhang ArgoZhang deleted the feat-univer branch January 24, 2026 04:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps the UniverSheet component version from 10.0.7 to 10.0.9. The changes consolidate the library's asset loading strategy by removing numerous locale and component-specific files in favor of a single bundled approach, and improves the loading UI experience with a more polished backdrop/loading indicator.

Changes:

  • Updated version from 10.0.7 to 10.0.9 in the .csproj file
  • Removed multiple locale files and component-specific JavaScript/CSS bundles in favor of using a consolidated univer-bundle.js
  • Refactored loading UI with new CSS file, improved loading state management, and added ShowLoading parameter
  • Added firstPush tracking to data-service for better initial load handling

Reviewed changes

Copilot reviewed 83 out of 133 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
BootstrapBlazor.UniverSheet.csproj Version bump from 10.0.7 to 10.0.9
univer.js Simplified asset loading by removing granular script/link loading in favor of single bundle
UniverSheet.razor.js Enhanced loading backdrop management with firstPush flag and timing control
UniverSheet.razor.cs Added ShowLoading parameter (default true) for controlling loading UI visibility
UniverSheet.razor Refactored loading backdrop HTML structure with conditional rendering
data-service.js Added firstPush flag tracking to distinguish initial data push
plugin.js Removed Chinese comment
css/univer-sheet.bundle.css New consolidated CSS file with improved loading backdrop styling
wwwroot/univer/* Removed numerous locale files, component-specific bundles, and React libraries (replaced by single bundle)
Comments suppressed due to low confidence (3)

src/components/BootstrapBlazor.UniverSheet/wwwroot/univer.js:18

  • Avoid automated semicolon insertion (90% of all statements in the enclosing function have an explicit semicolon).
    const lang = sheet.lang.replace('-', '')

src/components/BootstrapBlazor.UniverSheet/wwwroot/univer.js:19

  • Avoid automated semicolon insertion (90% of all statements in the enclosing function have an explicit semicolon).
    const langStr = lang.charAt(0).toUpperCase() + lang.slice(1)

src/components/BootstrapBlazor.UniverSheet/wwwroot/univer.js:103

  • Avoid automated semicolon insertion (90% of all statements in the enclosing function have an explicit semicolon).
    }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

sheet.lang = sheet.lang ?? 'en-US';
await loadAssets(sheet.lang);
const { el } = sheet;
const { LocaleType, merge } = UniverCore;
Copy link

Copilot AI Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable LocaleType.

Suggested change
const { LocaleType, merge } = UniverCore;
const { merge } = UniverCore;

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(UniverSheet): bump version 10.0.9

3 participants