[valkey] Port #615, #639, #701 & fix custom config never being used #715
+31
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
One thing I was uncertain about is the usage of cloudpirates.namespace vs .Release.Namespace. In the Redis chart the cloudpirates variable seems to be used but here it seems to be Release.Namespace. I've kinda blindly find & replaced it with cloudpirates.namespace in this PR, but happy to revert depending on what the choice should be. |
clrxbl
changed the title
dloewen2
added
enhancement
dloewen2
reviewed
Dec 10, 2025
Member
dloewen2
left a comment
dloewen2
left a comment
There was a problem hiding this comment.
Looks good to me, only thing missing for me is the value config.mountPath in the ReadMe.md
Contributor
Author
resolved |
dloewen2
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Ports Redis Helm chart PRs #615, #639 and #701 to the Valkey chart. Also fixes a critical issue where the custom Valkey config is never being mounted so Helm chart config options are not being respected.
Benefits
Sentinel failover is unreliable without these PRs and has impacted our production workloads as a result.
Possible drawbacks
Default behaviour of announcing hostnames can potentially break something, but should be done going forward. Can be reverted by the user with Helm chart setting sentinel.config.announceHostnames=false. Refer to #628 for one user complaining about this behaviour change.
Applicable issues
N/A but fixes Valkey Sentinel failover
Additional information
N/A
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.md