create update proposal review

lib/angular-ui/src/lib/atoms/card/card.component.ts

@@ -8,8 +8,6 @@ import { DefineCustomElement } from '../../define-custom-element';
   selector: 'cg-card',
   standalone: true,
   changeDetection: ChangeDetectionStrategy.OnPush,
-  template: `
-    <ng-content />
-  `,
+  template: `<ng-content />`,
 })
 export class CardComponent {}

lib/angular-ui/src/lib/atoms/icon-btn/icon-btn.component.ts

@@ -8,8 +8,6 @@ import { DefineCustomElement } from '../../define-custom-element';
   selector: 'cg-icon-btn',
   standalone: true,
   changeDetection: ChangeDetectionStrategy.OnPush,
-  template: `
-    <ng-content />
-  `,
+  template: `<ng-content />`,
 })
 export class IconBtnComponent {}

lib/angular-ui/src/lib/atoms/icons/check-circle-icon/check-circle-icon.component.ts

@@ -8,8 +8,6 @@ import { DefineCustomElement } from '../../../define-custom-element';
   selector: 'cg-check-circle-icon',
   standalone: true,
   changeDetection: ChangeDetectionStrategy.OnPush,
-  template: `
-    <ng-content />
-  `,
+  template: `<ng-content />`,
 })
 export class CheckCircleIconComponent {}

lib/angular-ui/src/lib/atoms/icons/dash-circle-icon/dash-circle-icon.component.ts

@@ -8,8 +8,6 @@ import { DefineCustomElement } from '../../../define-custom-element';
   selector: 'cg-dash-circle-icon',
   standalone: true,
   changeDetection: ChangeDetectionStrategy.OnPush,
-  template: `
-    <ng-content />
-  `,
+  template: `<ng-content />`,
 })
 export class DashCircleIconComponent {}

lib/angular-ui/src/lib/atoms/icons/profile-icon/profile-icon.component.ts

@@ -8,8 +8,6 @@ import { DefineCustomElement } from '../../../define-custom-element';
   selector: 'cg-profile-icon',
   standalone: true,
   changeDetection: ChangeDetectionStrategy.OnPush,
-  template: `
-    <ng-content />
-  `,
+  template: `<ng-content />`,
 })
 export class ProfileIconComponent {}

lib/angular-ui/src/lib/atoms/radio-input/radio-input.component.ts

@@ -29,9 +29,7 @@ type TouchedFn = () => void;
       multi: true,
     },
   ],
-  template: `
-    <ng-content />
-  `,
+  template: `<ng-content />`,
 })
 export class RadioInputComponent implements ControlValueAccessor {
   private notifyChange: ChangeFn = () => {};

lib/angular-ui/src/lib/atoms/text-btn/text-btn.component.ts

@@ -8,8 +8,6 @@ import { DefineCustomElement } from '../../define-custom-element';
   selector: 'cg-text-btn',
   standalone: true,
   changeDetection: ChangeDetectionStrategy.OnPush,
-  template: `
-    <ng-content />
-  `,
+  template: `<ng-content />`,
 })
 export class TextBtnComponent {}

lib/angular-ui/src/lib/molecules/collapsible/collapsible.component.ts

@@ -8,8 +8,6 @@ import { DefineCustomElement } from '../../define-custom-element';
   selector: 'cg-collapsible',
   standalone: true,
   changeDetection: ChangeDetectionStrategy.OnPush,
-  template: `
-    <ng-content />
-  `,
+  template: `<ng-content />`,
 })
 export class CollapsibleComponent {}

lib/angular-ui/src/lib/molecules/copy-to-clipboard/copy-to-clipboard.component.ts

@@ -15,9 +15,7 @@ import { DefineCustomElement } from '../../define-custom-element';
   selector: 'cg-copy-to-clipboard',
   standalone: true,
   changeDetection: ChangeDetectionStrategy.OnPush,
-  template: `
-    <ng-content />
-  `,
+  template: `<ng-content />`,
 })
 export class CopyToClipboardComponent {
   public readonly value =

lib/angular-ui/src/lib/molecules/dropdown/dropdown-btn-menu-item/dropdown-btn-menu-item.component.ts

@@ -8,8 +8,6 @@ import { DefineCustomElement } from '../../../define-custom-element';
   selector: 'cg-dropdown-btn-menu-item',
   standalone: true,
   changeDetection: ChangeDetectionStrategy.OnPush,
-  template: `
-    <ng-content />
-  `,
+  template: `<ng-content />`,
 })
 export class DropdownBtnMenuItemComponent {}

lib/angular-ui/src/lib/molecules/dropdown/dropdown-link-menu-item/dropdown-link-menu-item.component.ts

@@ -17,9 +17,7 @@ import { DefineCustomElement } from '../../../define-custom-element';
   selector: 'cg-dropdown-link-menu-item',
   standalone: true,
   changeDetection: ChangeDetectionStrategy.OnPush,
-  template: `
-    <ng-content />
-  `,
+  template: `<ng-content />`,
 })
 export class DropdownLinkMenuItemComponent {
   public readonly routerLink =

lib/angular-ui/src/lib/molecules/dropdown/dropdown-menu/dropdown-menu.component.ts

@@ -8,8 +8,6 @@ import { DefineCustomElement } from '../../../define-custom-element';
   selector: 'cg-dropdown-menu',
   standalone: true,
   changeDetection: ChangeDetectionStrategy.OnPush,
-  template: `
-    <ng-content />
-  `,
+  template: `<ng-content />`,
 })
 export class DropdownMenuComponent {}

lib/angular-ui/src/lib/molecules/dropdown/dropdown-trigger/dropdown-trigger.component.ts

@@ -15,9 +15,7 @@ import { DefineCustomElement } from '../../../define-custom-element';
   selector: 'cg-dropdown-trigger',
   standalone: true,
   changeDetection: ChangeDetectionStrategy.OnPush,
-  template: `
-    <ng-content />
-  `,
+  template: `<ng-content />`,
 })
 export class DropdownTriggerComponent {
   public readonly isIconBtn =

lib/angular-ui/src/lib/molecules/dropdown/dropdown.component.ts

@@ -15,9 +15,7 @@ import { DefineCustomElement } from '../../define-custom-element';
   selector: 'cg-dropdown',
   standalone: true,
   changeDetection: ChangeDetectionStrategy.OnPush,
-  template: `
-    <ng-content />
-  `,
+  template: `<ng-content />`,
 })
 export class DropdownComponent {
   public readonly anchorAlign = input<HTMLCgDropdownElement['anchorAlign']>();

lib/angular-ui/src/lib/molecules/image-uploader-btn/image-uploader-btn.component.ts

@@ -19,9 +19,7 @@ type ImagesSelectedEvent = CustomEvent<
   selector: 'cg-image-uploader-btn',
   standalone: true,
   changeDetection: ChangeDetectionStrategy.OnPush,
-  template: `
-    <ng-content />
-  `,
+  template: `<ng-content />`,
 })
 export class ImageUploaderBtnComponent {
   @HostListener('imagesSelected', ['$event'])

lib/angular-ui/src/lib/organisms/footer/footer.component.ts

@@ -14,9 +14,7 @@ import { defineCustomElement } from '@cg/ui/dist/components/cg-footer';
   selector: 'cg-footer',
   standalone: true,
   changeDetection: ChangeDetectionStrategy.OnPush,
-  template: `
-    <ng-content />
-  `,
+  template: `<ng-content />`,
 })
 export class FooterComponent {
   public readonly links = input.required<HTMLCgFooterElement['links']>();

lib/angular-ui/src/lib/organisms/navbar/navbar.component.ts

@@ -14,9 +14,7 @@ import {
   selector: 'cg-navbar',
   standalone: true,
   changeDetection: ChangeDetectionStrategy.OnPush,
-  template: `
-    <ng-content />
-  `,
+  template: `<ng-content />`,
 })
 export class NavbarComponent {
   public readonly homeUrl = input.required<HTMLCgNavbarElement['homeUrl']>();

lib/angular-ui/src/lib/organisms/sidenav/sidenav.component.ts

@@ -17,9 +17,7 @@ export { NavLink, NavLinkCategory } from '@cg/ui/dist/types';
   selector: 'cg-sidenav',
   standalone: true,
   changeDetection: ChangeDetectionStrategy.OnPush,
-  template: `
-    <ng-content />
-  `,
+  template: `<ng-content />`,
 })
 export class SidenavComponent {
   public readonly homeUrl = input.required<HTMLCgSidenavElement['homeUrl']>();

prettier.config.cjs

@@ -3,7 +3,7 @@ module.exports = {
   singleQuote: true,
   trailingComma: 'all',
   arrowParens: 'avoid',
-  htmlWhitespaceSensitivity: 'ignore',
+  htmlWhitespaceSensitivity: 'strict',
   plugins: ['prettier-plugin-astro'],
   overrides: [
     {

src/frontend/src/app/core/api/commit-review/commit-review-api.mapper.ts

@@ -59,7 +59,6 @@ export function mapGetProposalReviewCommitResponse(
 ): GetProposalReviewCommitResponse {
   return {
     id: res.id,
-    listId: res.id,
     proposalReviewId: res.proposal_review_commit.proposal_review_id,
     userId: res.proposal_review_commit.user_id,
     createdAt: fromCandidDate(res.proposal_review_commit.created_at),
@@ -74,17 +73,17 @@ export function mapGetProposalReviewCommitResponse(
 function mapReviewCommitRequestDetails(
   req: ReviewCommitDetails,
 ): ReviewCommitState {
-  if (req.reviewed === false) {
-    return { not_reviewed: null };
+  if (req.reviewed) {
+    return {
+      reviewed: {
+        highlights: req.highlights,
+        comment: toCandidOpt(req.comment),
+        matches_description: toCandidOpt(req.matchesDescription),
+      },
+    };
   }
 
-  return {
-    reviewed: {
-      highlights: req.highlights,
-      comment: toCandidOpt(req.comment),
-      matches_description: toCandidOpt(req.matchesDescription),
-    },
-  };
+  return { not_reviewed: null };
 }
 
 function mapReviewCommitResponseDetails(

src/frontend/src/app/core/api/commit-review/commit-review-api.model.ts

@@ -14,13 +14,12 @@ export interface DeleteProposalReviewCommitRequest {
 }
 
 export interface GetProposalReviewCommitResponse {
-  id: string | null;
-  listId: string;
+  id: string;
   proposalReviewId: string;
   userId: string;
   createdAt: Date;
   lastUpdatedAt: Date | null;
-  commitSha: string;
+  commitSha: string | null;
   details: ReviewCommitDetails;
 }
 
@@ -36,5 +35,5 @@ export interface ReviewedCommitDetails {
 }
 
 export interface NotReviewedCommitDetails {
-  reviewed: false;
+  reviewed: false | null;
 }

src/frontend/src/app/core/api/commit-review/commit-review-api.service.spec.ts

@@ -66,7 +66,7 @@ describe('CommitReviewApiService', () => {
           proposal_review_id: 'proposalReviewId',
           user_id: 'userId',
           commit_sha: 'commitSha',
-          created_at: new Date(2024, 1, 1, 0, 0, 0, 0).getTime().toString(),
+          created_at: new Date(2024, 1, 1, 0, 0, 0, 0).toISOString(),
           last_updated_at: [],
           state: {
             reviewed: {
@@ -80,7 +80,6 @@ describe('CommitReviewApiService', () => {
     };
     const commonResponse: GetProposalReviewCommitResponse = {
       id: 'id',
-      listId: 'id',
       userId: 'userId',
       commitSha: 'commitSha',
       proposalReviewId: 'proposalReviewId',

src/frontend/src/app/core/api/review/review-api.mapper.ts

@@ -14,6 +14,7 @@ import {
   GetProposalReviewRequest as GetProposalReviewApiRequest,
   GetMyProposalReviewRequest as GetMyProposalReviewApiRequest,
   ProposalReviewStatus as ProposalReviewStatusApi,
+  ProposalVote as ApiProposalVote,
 } from '@cg/backend';
 import {
   GetProposalReviewResponse,
@@ -23,7 +24,6 @@ import {
   ListProposalReviewsRequest,
   GetProposalReviewRequest,
   ProposalReviewStatus,
-  ProposalReviewVote,
 } from './review-api.model';
 
 export function mapCreateProposalReviewRequest(
@@ -34,7 +34,7 @@ export function mapCreateProposalReviewRequest(
     review_duration_mins: toCandidOpt(req.reviewDurationMins),
     summary: toCandidOpt(req.summary),
     build_reproduced: toCandidOpt(req.buildReproduced),
-    vote: [],
+    vote: mapProposalVoteRequest(req.vote),
   };
 }
 
@@ -48,7 +48,7 @@ export function mapUpdateProposalReviewRequest(
     review_duration_mins: toCandidOpt(req.reviewDurationMins),
     summary: toCandidOpt(req.summary),
     build_reproduced: toCandidOpt(req.buildReproduced),
-    vote: [],
+    vote: mapProposalVoteRequest(req.vote),
   };
 }
 
@@ -86,8 +86,7 @@ export function mapGetProposalReviewResponse(
     id: res.id,
     proposalId: review.proposal_id,
     userId: review.user_id,
-    // [TODO] - connect with API once it's implemented
-    vote: ProposalReviewVote.NoVote,
+    vote: mapProposalVoteResponse(review.vote),
     createdAt: fromCandidDate(review.created_at),
     lastUpdatedAt: fromCandidOptDate(review.last_updated_at),
     status: mapProposalReviewStatusResponse(review.status),
@@ -112,6 +111,32 @@ function mapProposalReviewStatusResponse(
   return ProposalReviewStatus.Draft;
 }
 
+function mapProposalVoteRequest(vote?: boolean | null): [] | [ApiProposalVote] {
+  switch (vote) {
+    case true: {
+      return [{ yes: null }];
+    }
+    case false: {
+      return [{ no: null }];
+    }
+    default: {
+      return [];
+    }
+  }
+}
+
+function mapProposalVoteResponse(vote: ApiProposalVote): boolean | null {
+  if ('yes' in vote) {
+    return true;
+  }
+
+  if ('no' in vote) {
+    return false;
+  }
+
+  return null;
+}
+
 function getReviewImages(): ImageSet[] {
   return [
     {

src/frontend/src/app/core/api/review/review-api.model.ts

@@ -3,17 +3,18 @@ import { ImageSet } from '@cg/angular-ui';
 
 export interface CreateProposalReviewRequest {
   proposalId: string;
-  summary: string | null;
-  reviewDurationMins: number | null;
-  buildReproduced: boolean | null;
-  reproducedBuildImageId: string | null;
+  summary?: string | null;
+  reviewDurationMins?: number | null;
+  buildReproduced?: boolean | null;
+  vote?: boolean | null;
 }
 
 export interface UpdateProposalReviewRequest {
   proposalId: string;
-  reviewDurationMins: number | null;
-  summary: string | null;
-  buildReproduced: boolean | null;
+  reviewDurationMins?: number | null;
+  summary?: string | null;
+  buildReproduced?: boolean | null;
+  vote?: boolean | null;
 }
 
 export interface ListProposalReviewsRequest {
@@ -33,7 +34,7 @@ export interface GetProposalReviewResponse {
   id: string;
   proposalId: string;
   userId: string;
-  vote: ProposalReviewVote;
+  vote: boolean | null;
   createdAt: Date;
   lastUpdatedAt: Date | null;
   status: ProposalReviewStatus;
@@ -63,7 +64,7 @@ export interface ProposalCommitReviewHighlight {
 export interface ProposalCommitReviewSummary {
   proposalId: string;
   commitId: string;
-  commitSha: string;
+  commitSha: string | null;
   highlights: ProposalCommitReviewHighlight[];
   totalReviewers: number;
   reviewedCount: number;