Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 30, 2026

Addresses 6 code quality and consistency issues identified in PR review.

Changes

  • Store locale default: Changed CreateStoreSchema locale from 'en' to 'bn' to match Prisma schema default
  • Retention calculation performance: Replaced O(n²) array includes() with O(1) Set.has() lookup
    // Before: O(n²)
    const retained = customerIdsInPeriod.filter(id => previousPeriodCustomerIds.includes(id));
    
    // After: O(n)
    const previousPeriodSet = new Set(previousPeriodCustomerIds);
    const retained = customerIdsInPeriod.filter(id => previousPeriodSet.has(id));
  • Production console cleanup: Removed debug console.log statements from analytics dashboard client component
  • React Compiler pattern: Restored eslint-disable directive for useReactTable to match established pattern in data-table.tsx
  • Playwright resource cleanup: Changed test teardown to close browser context (not just page) to prevent resource leaks
  • Free shipping threshold: Corrected threshold from 50 to 5000 BDT to match UI documentation

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI mentioned this pull request Jan 30, 2026
@vercel
Copy link

vercel bot commented Jan 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
stormcomui Ready Ready Preview, Comment Jan 30, 2026 6:59pm

…lc, remove console logs, fix Playwright cleanup, update shipping threshold

Co-authored-by: rafiqul4 <124497017+rafiqul4@users.noreply.github.com>
Copilot AI changed the title [WIP] Add localization for Bangladesh storefront and simplify checkout Fix locale default, retention performance, console logs, and test cleanup Jan 30, 2026
Copilot AI requested a review from rafiqul4 January 30, 2026 19:39
Base automatically changed from susmoycurrency to main February 2, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants