Don't use memory temp store.

[ggreer]

Summary by CodeRabbit

Release Notes

• Refactor
  • Optimized the compaction process by adjusting temporary storage handling in preparation and read phases, improving overall resource efficiency.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The change removes temp_store = MEMORY pragmas from SQLite C1Z options in two locations within the compaction process: the initial compaction setup and the per-file read-only apply phase. This eliminates in-memory temporary storage usage during compaction operations without altering control flow or public APIs.

Changes

Cohort / File(s)	Summary
SQLite Pragma Configuration pkg/synccompactor/compactor.go	Removed temp_store = MEMORY pragma from two C1Z option configurations: one in the compaction preparation phase and one in the read-only apply phase, reducing in-memory temporary storage usage

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Compaction: Remove WithOptimizeInserts(). #578: Conflicting pragma changes — while this PR removes temp_store = MEMORY from C1Z options, the retrieved PR makes MEMORY temp_store mandatory, representing opposing configuration strategies for the same compactor component.

Suggested reviewers

• johnallers
• kans

Poem

🐰 Memory freed in compaction's dance,
Pragmas removed, a lighter trance,
SQLite stores on disk so true,
No MEMORY limbs for this bunny's brew! 🌙

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Don't use memory temp store' directly and clearly describes the main change: removing the temp_store = MEMORY pragma to eliminate in-memory temporary storage usage.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

---

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c025486 and 9cffc15.

📒 Files selected for processing (1)

• pkg/synccompactor/compactor.go

💤 Files with no reviewable changes (1)

• pkg/synccompactor/compactor.go

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: go-test (1.25.2, windows-latest)
• GitHub Check: go-test (1.25.2, ubuntu-latest)

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}