-
Notifications
You must be signed in to change notification settings - Fork 504
Submission - Replace plaintext with relationship on lookup - 7.6 #4904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Atmire-Kristof
wants to merge
6
commits into
DSpace:dspace-7_x
Choose a base branch
from
atmire:w2p-136580_Replace-plaintext-relationship-7.6
base: dspace-7_x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Submission - Replace plaintext with relationship on lookup - 7.6 #4904
Atmire-Kristof
wants to merge
6
commits into
DSpace:dspace-7_x
from
atmire:w2p-136580_Replace-plaintext-relationship-7.6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cts-queue' into w2p-136580_Replace-plaintext-relationship-7.6
|
Hi @Atmire-Kristof, |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
component: configurable entities
related to configurable entities
component: submission
merge conflict
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
This PR changes the submission relationship lookup to make the (first) selected relationship replace the plain text value the lookup started from, if it did.
Instructions for Reviewers
Technical details:
ReplaceRelationshipActionwill be created instead of the usualAddRelationshipAction. This only happens for the first selected relationship, the rest sends aAddRelationshipActionfor each selection.ReplaceRelationshipAction:How to test:
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.