Update DSO creation and edition selectors in admin menu to use more specific authorization endpoints #4918
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
This modification updates the community, collection, and item selectors used in the DSO admin menu for creation and edition. This ensures that the listed objects are correctly filtered by the user's permissions, which specifically addresses the item selector for edition that currently does not filter items based on the user's edit authorization. Additionally, some selectors now utilize the more specific endpoints,
findAddAuthorizedandfindEditAuthorized(introduced in the backend PR), instead of the previously usedfindAdminAuthorizedendpoint.Instructions for Reviewers
List of changes in this PR:
findAddAuthorizedandfindEditAuthorized).ADDorWRITEorADMIN).Note that because the UI currently requires administrator permissions to edit communities and collections, these two selectors use the
findAdminAuthorizedmethod.The key test is to verify that the Item selector for edition now only shows items that the logged-in user is authorized to edit. For detailed instructions on how to test, please refer to the backend PR: DSpace/DSpace#11646
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.