-
-
Notifications
You must be signed in to change notification settings - Fork 258
feat: modernize preact demo to latest versions #496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Update Preact from 8.2.6 to 10.26.9 (major version upgrade) - Update Preact CLI from 2.1.0 to 3.5.1 - Update ESLint from 4.9.0 to 9.16.0 with modern configuration - Update Jest from 21.2.1 to 29.7.0 with jsdom environment - Replace outdated Babel setup with modern configuration - Convert class components to function components with hooks (App, PrivateRoute) - Remove preact-compat dependency (not needed with Preact X) - Add proper JSX transformation setup with Babel Co-authored-by: DavidWells <DavidWells@users.noreply.github.com>
|
Does preact still use babel and not vite? @claude please verify this is a modern 2025 setup for preact. Checkout the preact repo and examples please |
|
💬 Claude Code execution complete 📊 Execution Info: Pull Request #496 | Unknown (402 files) | @DavidWells 🚀 Automated management executed: 💡 Example commands for Claude: 🔍 Analysis & Review:
🛠️ Tasks & Implementation:
📚 Management & Operations:
🔀 PR Specific:
🔄 Rerun: You can run again anytime with |
|
Claude finished @DavidWells's task —— View job Analyzing Preact Demo Setup ✅Verified the modernized Preact demo setup and compared against 2025 best practices. Todo List:
📋 Analysis ResultsWhat This PR Modernizes:
🔧 Build Tool Analysis: preact-cli vs ViteCurrent Setup (preact-cli):
Alternative (Vite):
✅ Recommendation: Current Setup is Modern for 2025Why this setup is appropriate:
For this analytics library demo specifically:
🚀 Optional Future EnhancementIf you wanted to modernize further to Vite (not necessary, but possible):
Verdict: This PR successfully modernizes the Preact demo to 2025 standards. The use of preact-cli over Vite is appropriate and the Babel configuration serves its intended purpose for testing. |
Modernizes the preact demo with latest versions and build tools
Closes #476
Generated with Claude Code