Return meta information from DoUpdate and Enroll #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanVS
approved these changes
May 14, 2025
Contributor
IanVS
left a comment
IanVS
left a comment
There was a problem hiding this comment.
Looks good to me, though I think technically it's a breaking change, right? It doesn't seem like we have published any "release" of the package, and it's unclear to me whether anyone is using this outside of Defined Networking. But maybe it's at least worth prefixing the PR title with "Breaking:" or something?
Member
Author
|
@IanVS yes it's a breaking change but I don't think we have any real consumers of this repo. It's public only to support mobile_nebula. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.