Skip to content

Conversation

Copy link

Copilot AI commented Dec 2, 2025

Addresses review feedback from #52 to remove ThreadAbortException checks, which are obsolete in .NET Core 2.0+ and .NET 5+.

  • Removed ThreadAbortException from critical exception checks in ExecuteRdmActionCommand and ExecuteWindowRecStartCommand
// Before
if (ex is OutOfMemoryException || ex is StackOverflowException || ex is ThreadAbortException)

// After
if (ex is OutOfMemoryException || ex is StackOverflowException)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: pacmancoder <3994505+pacmancoder@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on window recording support implementation Remove obsolete ThreadAbortException checks Dec 2, 2025
Copilot AI requested a review from pacmancoder December 2, 2025 13:33
@pacmancoder pacmancoder marked this pull request as ready for review December 2, 2025 13:34
@pacmancoder pacmancoder merged commit ac94040 into feat/window-monitoring Dec 2, 2025
18 checks passed
@pacmancoder pacmancoder deleted the copilot/sub-pr-52 branch December 2, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants