LIMS-2016: Only check snapshot images for data collections #1017
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-2016
Summary:
When viewing a list of data collections, the list of id's is sent to the backend to see whether they have snapshots available on disk. Unfortunately, when there are robot actions in the list, the robot action ids are added to the list of ids to check.
The backend fails to verify the ids are relevant, so checks for snapshots assuming each id is for a data collection, but as robot action ids are smaller numbers than data collection ids, it often ends up looking at years old data collections from other proposals and beamlines. Sometimes these have snapshots in invalid locations, leading to a PHP error.
Changes:
To test: