Skip to content

Conversation

@mjsarfatti
Copy link

@mjsarfatti mjsarfatti commented Sep 16, 2025

What is this PR about?

This PR allows installation of Dokploy on remote servers as sudo users. It goes in pair with the main PR Dokploy/dokploy#2619

Checklist

Before submitting this PR, please make sure that:

  • You created a dedicated branch based on the canary branch.
  • You have read the suggestions in the CONTRIBUTING.md file https://github.com/Dokploy/dokploy/blob/canary/CONTRIBUTING.md#pull-request
  • You have tested this PR in your local instance.
    NOTE: I have not tested the script on each and every OS, only on a fresh Ubuntu VPS. I'm asking for help testing on all different supported OSs.

Issues related (if applicable)

closes Dokploy/dokploy#1126

Copy link
Contributor

@designorant designorant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please use Biome to format according to project requirements? There's a lot of stylistic changes in here making reviewing it so much harder, see:

@mjsarfatti
Copy link
Author

Hi, I tried my best not to touch whitespace but I must have missed some editor rules. This said, Biome doesn't support Shell nor Markdown files, is there anything else you'd like me to use? Perhaps shell-format for .sh and Prettier for .mdx?

Ps: Generally speaking I've noticed styling inconsistencies (such as trailing whitespaces, mix of tabs and spaces in the same files, indentation inconsistencies, etc.) across files

@designorant
Copy link
Contributor

Oh, good point! It's been a while since I contributed. I only commented based on different whitespace, but it does look like Dokploy repos are ripe1 for a config tweak. Apologies @mjsarfatti!

Footnotes

  1. Biome being the official formatter doesn't support MDX but Prettier is discouraged therefore users are technically welcome to contribute with whatever format they use.

@designorant
Copy link
Contributor

@mjsarfatti FYI: Dokploy/dokploy#2631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow multiserver deployment as non-root user

2 participants