Make the IMU implementation more generic so it can be tested. #255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the AltIMU to the Rov class. It also fixes #168 by reading the AltIMU (and voltage and current) sensors on their own Observable.
Details:
In order to test the Rov class, the AltIMU must be able to mocked. The mocked class must not rely on I2C and needs to have some interface which can be implemented by the test code. Following a similar strategy to the Maestro code, the Rov requests a generic IMU which implements 5 sensor interfaces.
This change removes the dependency between the AltIMU and rx observables by only exposing simple get methods (linking these to an rx observable can be done from the rov class itself).
Future work will be creating proper tests in
RovTestandRovSimulatorclasses