-
Notifications
You must be signed in to change notification settings - Fork 0
Upgrade gradle, update dependencies and cache circleci builds #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
20e6495 to
e70566a
Compare
|
@ConnorWhalen This PR just became critical. Looks like Gradle 2.14 has been removed from the Personal Package Archives (PPA) |
|
From the CCI logs:
From vagrant console:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good and I was able to cleanly run the captain playbook and build using gradle 3.4 👍
Upgrade gradle, update dependencies and cache circleci builds
This PR builds on top of #274 and should be reviewed after that has been merged.Circle CI now caches the gradle version and the downloaded gradle dependencies between builds. This ends up saving about a minute of build time (reduced from 3:30 to 2:30 🎉 ). If we ever go to remove dependencies from the project, there is an option in the build page to re-build the project without a cache. This will make circle ci create a brand new cache for subsequent builds.
The version of gradle was updated to 3.4 to fix #268 . The compiler warning about the deprecated
Constructor DefaultSourceDirectorySetwas solved when updating the project dependencies. Updating this dependencies did however deprecate some of the features that we use in these libraries. Most changes were simple apart from the deprecation ofObservable#create. I use this method often when I have to poll from a source, so I'll have to get used to creating the sequence in other ways. In our case it was being used by the joystick code. I was able to rearrange it to not use create. Will need to test on the joystick before we push.