Implement Bluetooth Sensor

[ConnorWhalen]

#242

On the ROV side, the BluetoothReader listens for messages on the bluetooth serial port and broadcasts BluetoothValues

On Topsides, the BluetoothView is a console view that displays each emitted BluetoothValue

[cal-pratt]

Only concern is closing the inputstream of the serial port object during calls to onNext. Apart from that and a few nitpicks LGTM

Ship it.

[cal-pratt]

This can be final.

[cal-pratt]

Nitpick:

I've been opting for single tabs in all indent cases and to place the ( on a new line to distinguish where the parameters end and the method begins.

public BluetoothReader(
    final String comPortName,
    final String comPort,
    final int connectionTimeout,
    final int baudRate
) {
    this.comPortName = comPortName;
    this.comPort = comPort;
    this.connectionTimeout = connectionTimeout;
    this.baudRate = baudRate;
}

[cal-pratt]

Will calls to close on the inputstream cause the serial port to close?

[cal-pratt]

Maybe don't use the inputstream as a try-with resource and wait for the proper cleanup in onUnsubscribe which will close all connections from/to the serial port.

[cal-pratt]

Not sure if this will also kill the input. Calling close on a wrapped stream usually closes the initial stream.

[ConnorWhalen]

The test implementation i had called scanner.close and it worked fine. We'll confirm it when it's tested on hardware

…

On Jun 11, 2017, at 8:59 PM, Cal Pratt ***@***.***> wrote: @cal-pratt commented on this pull request. In src/main/java/com/easternedgerobotics/rov/io/BluetoothReader.java: > + throw new RuntimeException(e); + } + } + + /** + * Read the next line of input from the serial port if it exists. + * + * @param serialPort the bluetooth serialPort. + * @param observer the listener to this receiver. + * @return the serial port + */ + @OverRide + protected SerialPort next(final SerialPort serialPort, final Observer<? super BluetoothValue> observer) { + try { + final InputStream inputStream = serialPort.getInputStream(); + try (final Scanner scanner = new Scanner(inputStream)) { Not sure if this will also kill the input. Calling close on a wrapped stream usually closes the parent stream. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.