Skip to content

14997 impersonate customers sa in gcp vector plugin error logging #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ldrozdz93 merged 2 commits into from
Nov 21, 2024
Merged

14997 impersonate customers sa in gcp vector plugin error logging #15

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0cde7b
add more error logging on impersonation failure
ldrozdz93 Nov 20, 2024
b1df78b
tidy
ldrozdz93 Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions src/gcp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,17 +356,32 @@ async fn do_fetch_impersonated_token(
}

async fn token_from_json(resp: Response) -> crate::Result<Token> {
if !resp.status().is_success() {
let token_err = resp.json::<TokenErr>().await?;
let is_success = resp.status().is_success();
let resp = resp.bytes().await?;
if !is_success {
error!(
message = "No success in response.",
raw_resp = String::from_utf8_lossy(&resp).into_owned(),
);
let token_err: TokenErr = serde_json::from_slice(&resp)?;
return Err(token_err.into())
}

#[derive(Deserialize)]
#[serde(rename_all = "camelCase")]
struct TokenCamelCase {
access_token: String,
expire_time: String,
}
let token = resp.json::<TokenCamelCase>().await?;
let token: TokenCamelCase = serde_json::from_slice(&resp.clone()).map_err(|e| {
error!(
message = "Failed to parse OAuth token JSON.",
error = %e,
raw_resp = String::from_utf8_lossy(&resp).into_owned(),
);
e
})?;

let remapped = json!({
"access_token": token.access_token,
"token_type": "Bearer",
Expand Down
Loading