fix: allow --help/--version without provider credentials #11
+192
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Parse CLI args before loading server to handle --help/-h and --version/-v early, avoiding credential validation - Make pino-pretty opt-in via LOG_PRETTY env var instead of auto-enabling in development mode (fixes "unable to determine transport target" error when devDependency not installed) - Move config validation from module top-level to validateConfig() function called only when starting the server Fixes Homebrew install failing on `lynkr --version` due to: 1. pino-pretty not bundled in production 2. Missing credentials throwing before args could be parsed Signed-off-by: Rui Chen <rui@chenrui.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Homebrew install failing on
lynkr --versiondue to:cc @vishalveerareddy123